Reduce ObjectData size: 24 bytes -> 11 bytes
#5722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
glebm
commented
Jan 25, 2023
glebm
commented
- Reduces sizes of integral fields.
- Merges boolean flags into a single field.
1. Reduces sizes of integral fields. 2. Merges boolean flags into a single field.
AJenbo
approved these changes
Jan 25, 2023
|
i kinda like it better this way as well |
|
Yeah, I'll do the same for other tables after the enum renaming PRs are merged. |
ephphatha
added a commit
that referenced
this pull request
Jun 17, 2023
Think this was unintentionally missed when doing the cleanup for #5722 The non-theme objects using the bookcase graphic are solid and before that PR these versions were also solid, so restoring that flag seems appropriate.
AJenbo
pushed a commit
that referenced
this pull request
Oct 23, 2023
Think this was unintentionally missed when doing the cleanup for #5722 The non-theme objects using the bookcase graphic are solid and before that PR these versions were also solid, so restoring that flag seems appropriate.
artifacts-storage
pushed a commit
to artifacts-storage/devilutionx-artifacts
that referenced
this pull request
Oct 23, 2023
…helves Think this was unintentionally missed when doing the cleanup for diasurgical/devilutionX#5722 The non-theme objects using the bookcase graphic are solid and before that PR these versions were also solid, so restoring that flag seems appropriate.
artifacts-storage
pushed a commit
to artifacts-storage/devilutionx-artifacts
that referenced
this pull request
Oct 23, 2023
…elves Think this was unintentionally missed when doing the cleanup for diasurgical/devilutionX#5722 The non-theme objects using the bookcase graphic are solid and before that PR these versions were also solid, so restoring that flag seems appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.