Ensure library theme bookcases are solid to match normal bookshelves #6232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Think this was unintentionally missed when doing the cleanup for #5722 The non-theme objects using the bookcase graphic are solid and before that PR these versions were also solid, so restoring that flag seems appropriate.
|
Actually turns out the library versions were always non-solid, I was just looking at the wrong column in the table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6691
I'm not sure if there's ever a situation where a library theme room is unnavigable if the bookcase is solid, seems more likely that this was an oversight and both bookcases should have been solid to prevent issues like missiles colliding on spawn.