Backport action test #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking fields. (dotnet#76475) Related to dotnet#73920.
* Update PublishData.json for telmet branch
An implementation of INotificationService is [now required](https://github.com/dotnet/roslyn/pull/76510/files#diff-ee57f8ea8866dad6ed1842766c60de5011571b13c376c524a53301d46714a2f8R268) for GetExtractInterfaceOptions. This change allows OmniSharp to provide a no-op implementation. Also removes the use of WaitAndGetResults from the OmniSharp extract class and interface option services.
Applies fixups for feedback left on dotnet#75312
…-main style program'
For a full source build there should be no need for $(NetPrevious) to be included. Having it there creates complications in the build as we end up depending on projects that are not built during source build.
…76617) Resolves microsoft/vscode-dotnettools#1686 When vscode is installed in (or an extension assembly is loaded from) a path that contains a URI reserved character, the server crashes. This is because VS-MEF (for compatibility with clr behavior) sets the code base to a file URI with an unencoded path. When parsing the URI, some reserved characters cause the path component to be incorrectly split into query or fragment components if unescaped. Then we get an invalid file path from the URI and cannot load the extension dll.
…rlaod resolution to change
draft until snap
* Simplify naming style parsing * Simplify naming style preferences construction and make ordering deterministic if priorities are specified * Cleanup * Tests * Fix
…rload resolution to change. (dotnet#76646) Fixes dotnet#76645
* Attempt to reduce allocations in the C# lexer ctor The lexer ctor shows as about 0.5% of all allocations over the lifetime of the RoslynCodeAnalysisProcess in the csharp editing speedometer tests. There was already the concept of the LexerCache which had some pooling usage in it. This PR moves a couple other members to it to allow for their pooling.
* Change SupportedPlatformData to use ImmutableArrays for it's data I'm looking at a different change to completion and the usage of IEnumerable and List in SupportedPlatformData was tripping it up. It's easy enough to just have it use ImmutableArrays instead. One concern would be additional allocations due to the IEnumerable -> ImmutableArray conversion. However, I don't think is an issue as the IEnumerable member is always passed in from a List except from AbstractSignatureHelpProvider. In that case, it's a constructed Linq Select/Concat expression, which is reused multiple times (and potentially enumerated multiple times in SupportedPlatformData). It's extremely likely that it's better to just realize that array once.
This accounted for a small amount (0.2%) of allocations during the typing scenario of the csharpediting speedometer test.
|
/backport to release/dev17.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.