Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine 2 transaction fee records if they are about the same product #146

Closed
wants to merge 4 commits into from
Closed

Combine 2 transaction fee records if they are about the same product #146

wants to merge 4 commits into from

Conversation

dickwolff
Copy link
Owner

Added

Fixes

  • 🐛 DEGIRO: When there are multiple transaction fee records for the same product, combine them into one.

Checklist

  • Added relevant changes to README (if applicable)
  • Added relevant test(s)
  • Updated GitVersion file and corresponding version in package.json

Related issue (if applicable)

Fixes #140

@dickwolff dickwolff force-pushed the feat/degiro-v3-buy-with-2-tx-fees branch from 515cf28 to 17d22c1 Compare January 4, 2025 13:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
src 100% 100% 0 ✔
src.converters 98% 89% 0 ✔
src.helpers 100% 100% 0 ✔
Summary 99% (1302 / 1320) 90% (667 / 741) 0 ✔

@ikruglov ikruglov mentioned this pull request Jan 4, 2025
Open
3 tasks
@dickwolff
Copy link
Owner Author

Closing in favor of proposed solution in #148

@dickwolff dickwolff closed this Jan 5, 2025
@dickwolff dickwolff deleted the feat/degiro-v3-buy-with-2-tx-fees branch January 15, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEGIRO - Buy record in French (Belgium)
1 participant
@dickwolff