Combine 2 transaction fee records if they are about the same product

GitVersion.yml

@@ -1,4 +1,4 @@
-next-version: 0.21.0
+next-version: 0.21.1
 assembly-informational-format: "{NuGetVersion}"
 mode: ContinuousDeployment
 branches:

package.json

@@ -1,6 +1,6 @@
 {
   "name": "export-to-ghostfolio",
-  "version": "0.21.0",
+  "version": "0.21.1",
   "type": "module",
   "description": "Convert multiple broker exports to Ghostfolio import",
   "scripts": {

samples/degiro-export.csv

@@ -63,3 +63,6 @@ Datum,Tijd,Valutadatum,Product,ISIN,Omschrijving,FX,Mutatie,,Saldo,,Order Id
 23-08-2024,12:21,23-08-2024,,,DEGIRO courtesy,,EUR,0.24,EUR,61.30,
 23-08-2024,12:21,23-08-2024,,,DEGIRO courtesy,,EUR,0.61,EUR,61.06,
 14-09-2023,08:49,14-09-2023,PROSUS NV,NL0013654783,STOCK DIVIDEND: Koop 999 @ 0 EUR,,EUR,0.00,EUR,9999.99,
+13-09-2024,10:36,13-09-2024,ISHARES ASIA PACIFIC DIVIDEND UCITS ETF,IE00B14X4T88,Taxe sur les Opérations Boursières belge (TOB),,EUR,-0.45,EUR,8.31,72592e9b-xxxx-xxxx-xxxx-xxxxxxxxxxxx
+13-09-2024,10:36,13-09-2024,ISHARES ASIA PACIFIC DIVIDEND UCITS ETF,IE00B14X4T88,Frais DEGIRO de courtage et/ou de parties tierces,,EUR,-1.00,EUR,8.76,72592e9b-xxxx-xxxx-xxxx-xxxxxxxxxxxx
+13-09-2024,10:36,13-09-2024,ISHARES ASIA PACIFIC DIVIDEND UCITS ETF,IE00B14X4T88,"Achat 18 iShares Asia Pacific Dividend UCITS ETF USD (Dist)@20,81 EUR (IE00B14X4T88)",,EUR,-374.58,EUR,9.76,72592e9b-xxxx-xxxx-xxxx-xxxxxxxxxxxx

src/converters/degiroConverterV2.test.ts

@@ -35,7 +35,7 @@ describe("degiroConverterV2", () => {
       // Assert
       expect(actualExport).toBeTruthy();
       expect(actualExport.activities.length).toBeGreaterThan(0);
-      expect(actualExport.activities.length).toBe(24);
+      expect(actualExport.activities.length).toBe(25);
 
       done();
     }, () => { done.fail("Should not have an error!"); });

src/converters/degiroConverterV3.test.ts

@@ -35,7 +35,7 @@ describe("degiroConverterV3", () => {
       // Assert
       expect(actualExport).toBeTruthy();
       expect(actualExport.activities.length).toBeGreaterThan(0);
-      expect(actualExport.activities.length).toBe(24);
+      expect(actualExport.activities.length).toBe(25);
 
       done();
     }, () => { done.fail("Should not have an error!"); });

src/converters/degiroConverterV3.ts

@@ -185,7 +185,20 @@ export class DeGiroConverterV3 extends AbstractConverter {
           // Check wether it is a buy/sell record set.
           if (this.isBuyOrSellRecordSet(record, matchingRecord)) {
             result.activities.push(this.combineRecords(record, matchingRecord, security));
-          } else {
+          }
+          // Check wether both records are transaction fee records. This happens among others for Belgium customers. 
+          // In this case, combine the transaction fee records into one record.
+          else if (this.isTransactionFeeRecord(record, true) && this.isTransactionFeeRecord(matchingRecord, true)) {
+
+            // Combine the details and prepare the record for the next for-loop iteration.
+            record.description = `${record.description}; ${matchingRecord.description}`;
+            record.amount = `${parseFloat(record.amount) + parseFloat(matchingRecord.amount)}`;
+
+            records[idx + 1] = record;
+          }
+          else {
+
+            // It's a dividend record set.
             result.activities.push(this.mapDividendRecord(record, matchingRecord, security));
           }
         }