12 upgrade to numpy 2x #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the Numpy CI issue mentioned in #12 was not caused by any of our own code but version compatibility issues between Numpy and PyTorch. According to pytorch/pytorch#107302, PyTorch versions <=2.1 will only be compatible with Numpy 1.x, while PyTorch version >=2.2 will support also Numpy 2.x. However there currently seems to be an issue with the Windows builds of PyTorch with Numpy 2.0, causing our CI to fail, see pytorch/pytorch#128860. Since it is not urgent to fix the numpy version pin on our end, I suggest we wait a bit more and check back if the Windows build problems get fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12
We switch our linter from
flake8toruffto make use of its linting rule "NPY201" checking Numpy v2 compatibility, as described in the migration guide https://numpy.org/devdocs/numpy_2_0_migration_guide.html