Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deviceType to local peer discovery #451

Closed
gmaclennan opened this issue Jan 30, 2024 · 0 comments · Fixed by #461
Closed

Add deviceType to local peer discovery #451

gmaclennan opened this issue Jan 30, 2024 · 0 comments · Fixed by #461
Assignees
@gmaclennan

Comments

@gmaclennan
Copy link
Member

gmaclennan commented Jan 30, 2024 •
edited
Loading

Description

Locally discovered peers should share what type of device they are e.g. mobile or desktop. Initially we can just hardcode this as mobile (in peer.info), since we are targeting mobile for the MVP, but we should follow this up with sharing device type along with device name - see #452
This was referenced Jan 30, 2024
Closed
Merged
@gmaclennan gmaclennan self-assigned this Jan 31, 2024
gmaclennan added a commit that referenced this issue Jan 31, 2024
@gmaclennan
feat: share deviceType with local peers
b57be00 
fixes #451 and #452. Does not store deviceType in project deviceInfo
records, which will be done in a follow up PR (see #455) which also
requires changes to @mapeo/schema. `deviceType` is optional, and must be
set in the constructor of MapeoManager. Ideally this should not be
possible to change, but not sure how to enforce that.
@gmaclennan gmaclennan mentioned this issue Jan 31, 2024
Merged
gmaclennan added a commit that referenced this issue Feb 8, 2024
@gmaclennan
feat: share deviceType with local peers (#461)
4a2cb3c 
* feat: share deviceType with local peers

fixes #451 and #452. Does not store deviceType in project deviceInfo
records, which will be done in a follow up PR (see #455) which also
requires changes to @mapeo/schema. `deviceType` is optional, and must be
set in the constructor of MapeoManager. Ideally this should not be
possible to change, but not sure how to enforce that.

* Incorporate review comments

* fix bug in teardown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmaclennan gmaclennan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: share deviceType with local peers digidem/comapeo-core
1 participant
@gmaclennan