Share deviceType along with device name to connected peers #452
Assignees
Comments
This was referenced Jan 30, 2024
gmaclennan
added a commit
that referenced
this issue
Jan 31, 2024
fixes #451 and #452. Does not store deviceType in project deviceInfo records, which will be done in a follow up PR (see #455) which also requires changes to @mapeo/schema. `deviceType` is optional, and must be set in the constructor of MapeoManager. Ideally this should not be possible to change, but not sure how to enforce that.
gmaclennan
added a commit
that referenced
this issue
Feb 8, 2024
* feat: share deviceType with local peers fixes #451 and #452. Does not store deviceType in project deviceInfo records, which will be done in a follow up PR (see #455) which also requires changes to @mapeo/schema. `deviceType` is optional, and must be set in the constructor of MapeoManager. Ideally this should not be possible to change, but not sure how to enforce that. * Incorporate review comments * fix bug in teardown
|
Fixed in #461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Follow-up to #451 to share device type along with device name when sharing device info as part of the local peer discovery process.
deviceTypeshould bemobileordesktop. (NB. do we want to also shareandroidoriphone?)The text was updated successfully, but these errors were encountered: