-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: commit hooks for lint & package-lock chk #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've had a long-living branch for the pre-commit stuff. thanks for adding the additional checks - a nice improvement!
"*.js": [ | ||
"eslint --cache --fix" | ||
], | ||
"*.{js,css,md}": "prettier --write" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably don't need the css
here right? 😄
"*.{js,css,md}": "prettier --write" | |
"*.{js,md}": "prettier --write" |
* main: chore: update github action steps (#322) fix: fix mdns discovery (finally) (#323) chore: check npm lockfile version does not change (#321) chore: commit hooks for lint & package-lock chk (#320) feat: define sync capability per namespace (#319) feat: add namespace to peer pre-have messages (#314)
Non-urgent, but I've been meaning to add this for a while so that files are always formatted with prettier. This also adds a warning when you do
git pull
orgit checkout
if package-lock.json is different and whethernpm install
needs to be run