Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: commit hooks for lint & package-lock chk #320

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

gmaclennan
Copy link
Member

Non-urgent, but I've been meaning to add this for a while so that files are always formatted with prettier. This also adds a warning when you do git pull or git checkout if package-lock.json is different and whether npm install needs to be run

@gmaclennan gmaclennan self-assigned this Oct 5, 2023
@gmaclennan gmaclennan changed the title chore: add commit hooks for lint & pckage-lock chk chore: commit hooks for lint & package-lock chk Oct 5, 2023
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've had a long-living branch for the pre-commit stuff. thanks for adding the additional checks - a nice improvement!

"*.js": [
"eslint --cache --fix"
],
"*.{js,css,md}": "prettier --write"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably don't need the css here right? 😄

Suggested change
"*.{js,css,md}": "prettier --write"
"*.{js,md}": "prettier --write"

@gmaclennan gmaclennan merged commit cbb16ff into main Oct 5, 2023
@gmaclennan gmaclennan deleted the chore/husky branch October 5, 2023 12:19
gmaclennan added a commit that referenced this pull request Oct 5, 2023
* main:
  chore: update github action steps (#322)
  fix: fix mdns discovery (finally) (#323)
  chore: check npm lockfile version does not change (#321)
  chore: commit hooks for lint & package-lock chk (#320)
  feat: define sync capability per namespace (#319)
  feat: add namespace to peer pre-have messages (#314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants