fix: fix mdns discovery (finally) #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dedupe logic was incorrect, but in most cases the check in `handleServiceUp` was hiding that. Temporarily removing that check revealed the bug in a reproducible way.
Closed
gmaclennan
added a commit
that referenced
this pull request
Oct 5, 2023
* main: chore: update github action steps (#322) fix: fix mdns discovery (finally) (#323) chore: check npm lockfile version does not change (#321) chore: commit hooks for lint & package-lock chk (#320) feat: define sync capability per namespace (#319) feat: add namespace to peer pre-have messages (#314)
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 2, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dedupe logic was incorrect, but in most cases the check in
handleServiceUpwas hiding that. Temporarily removing that checkrevealed the bug in a reproducible way.