chore: update TypeScript to 5.5 #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably for us, TypeScript 5.5 introduces the [`@import` JSDoc tag][0], which we can start using. This required us to upgrade Typedoc and fix a small type error. [0]: https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/#the-jsdoc-import-tag
EvanHahn
commented
Aug 21, 2024
| @@ -13,6 +13,7 @@ import { | |||
| import { round } from './utils.js' | |||
| import { generate } from '@mapeo/mock-data' | |||
| import { setTimeout as delay } from 'timers/promises' | |||
| /** @import { MapeoDoc } from '@mapeo/schema' */ | |||
There was a problem hiding this comment.
@import is now possible with TS 5.5!
| @@ -102,6 +103,7 @@ test('CRUD operations', async (t) => { | |||
| const project = await manager.getProject(projectId) | |||
| /** @type {any[]} */ | |||
| const updates = [] | |||
| /** @type {Promise<MapeoDoc>[]} */ | |||
There was a problem hiding this comment.
I don't know why this was required as part of the upgrade, but it was easy to fix.
achou11
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably for us, TypeScript 5.5 introduces the
@importJSDoc tag, which we can start using.This required us to upgrade Typedoc and fix a small type error.