Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update TypeScript to 5.5 #759

Merged
merged 1 commit into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
200 changes: 158 additions & 42 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,10 @@
"streamx": "^2.15.1",
"tempy": "^3.1.0",
"ts-proto": "^1.156.7",
"typedoc": "^0.25.13",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc-plugin-missing-exports": "^2.2.0",
"typescript": "^5.4.5",
"typedoc": "^0.26.6",
"typedoc-plugin-markdown": "^4.2.5",
"typedoc-plugin-missing-exports": "^3.0.0",
"typescript": "^5.5.4",
"yazl": "^2.5.1"
},
"dependencies": {
Expand Down
3 changes: 3 additions & 0 deletions test-e2e/project-crud.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
import { round } from './utils.js'
import { generate } from '@mapeo/mock-data'
import { setTimeout as delay } from 'timers/promises'
/** @import { MapeoDoc } from '@mapeo/schema' */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@import is now possible with TS 5.5!


/** @satisfies {Array<import('@mapeo/schema').MapeoValue>} */
const fixtures = [
Expand Down Expand Up @@ -102,6 +103,7 @@ test('CRUD operations', async (t) => {
const project = await manager.getProject(projectId)
/** @type {any[]} */
const updates = []
/** @type {Promise<MapeoDoc>[]} */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this was required as part of the upgrade, but it was easy to fix.

const writePromises = []
project[schemaName].on('updated-docs', (docs) => updates.push(...docs))
let i = 0
Expand Down Expand Up @@ -278,6 +280,7 @@ test('CRUD operations', async (t) => {
await t.test(`create and delete ${schemaName}`, async () => {
const projectId = await manager.createProject()
const project = await manager.getProject(projectId)
/** @type {Promise<MapeoDoc>[]} */
const writePromises = []
let i = 0
while (i++ < CREATE_COUNT) {
Expand Down
Loading