Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows SSH client agent support #65

Closed
bryanl opened this issue Apr 29, 2016 · 3 comments
Closed

Windows SSH client agent support #65

bryanl opened this issue Apr 29, 2016 · 3 comments

Comments

@bryanl
Copy link
Contributor

bryanl commented Apr 29, 2016

Doctl uses a custom ssh client because it can't assume there is a ssh executable in the path. In order to be more friendly, there should exist support for SSH agents.

tbalthazar added a commit to tbalthazar/doctl that referenced this issue Jun 15, 2016
It doesn't work on Windows, since the custom ssh client for Windows
doesn't have agent support yet, as stated in issue digitalocean#65
@xmudrii
Copy link
Contributor

xmudrii commented Dec 7, 2016

Is this still a problem on Windows?

What about:
https://godoc.org/golang.org/x/crypto/ssh#Permissions
It talks about permit-ssh-agent.
But also more important - https://godoc.org/golang.org/x/crypto/ssh/agent

Is it possible to fix issue with this, is this still a issue?

cc @aybabtme @nanzhong

@xmudrii
Copy link
Contributor

xmudrii commented Mar 31, 2017

By looking more into issue, it looks like it's already implemented/fixed long time ago if I'm thinking of right thing.
On lines 77-85, as well as lines 188-194 of pkg/ssh/ssh_internal.go, you can see Agent Forwarding code.

Commit ec6d5c2 implemented it.

If this is right thing, this issue could be closed. If not, provide more context on what is needed if it's possible.

cc @viola @caueguerra @mauricio

@mauricio
Copy link
Contributor

mauricio commented Mar 7, 2018

Yup, this has been sorted out already.

@mauricio mauricio closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants