Add a --ssh-agent-forwarding flag #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't work on Windows, since the custom ssh client for Windows doesn't have agent support yet, as stated in issue digitalocean#65
|
Hello, Thanks for the suggestion. SSH agent forwarding is a needed feature. I have a few questions about the implementation, and I'll add those inline. |
| @@ -196,15 +196,15 @@ func withTestClient(t *testing.T, tFn testFn) { | |||
| } | |||
|
|
|||
| type TestConfig struct { | |||
| SSHFn func(user, host, keyPath string, port int) runner.Runner | |||
| SSHFn func(user, host, keyPath string, port int, agentForwarding bool) runner.Runner | |||
There was a problem hiding this comment.
I'm thinking this won't be the last option for SSH, so shouldn't we pass this option in a more forward-thinking way?
type SSHOptions map[string]interface{}
func(user, host, keyPath string, port int, options SSHOptions) runner.Runner {}This would allow you do something like:
opts[doctl.ArgsSSHAgentForwarding] = trueNot sure what this means long term, but it would solve the immediate issue of longer function signatures.
|
Hi Bryan, Thanks for the suggestion, it's definitely an improvement! Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't work on Windows, since the custom ssh client for Windows
doesn't have agent support yet, as stated in issue #65.
This feature has been requested in issue #77.
That's my first contribution to doctl, comments are welcome!