-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename DetachByDropletID function to Detach #214
Conversation
@xmudrii I think we're better off having |
@mauricio good reasoning, I agree on it.
I will update PR to add Detach function and update DetachByDropletID to do the same, but just with depreciation warning.
I would like to check is it okay to print warning to output or just to include deprecated in command description?
|
We can just include deprecated at the description. |
@mauricio is it good this way? 💯 |
I think we should instruct people to use |
@mauricio yep, I agree. Change pushed 😄 |
@mauricio travis failed on tip for unknown reason. can you restart build? |
I've gone ahead and restarted the build, looks like we're back to 💚 |
This PR renames function
detach-by-droplet-id
todetach
. Providing Droplet ID is as of April 4th, 2017 required and it's not possible to detach without anymore.detach-by-droplet-id
is long for a function and makes its usage inconvenient.This PR also regenerates mocks as it was forgotten in #208.
cc @mauricio @hugocorbucci @mchitten @magicgrl111