Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DetachByDropletID function to Detach #214

Merged
merged 1 commit into from
Apr 27, 2017

Conversation

xmudrii
Copy link
Contributor

@xmudrii xmudrii commented Apr 9, 2017

This PR renames function detach-by-droplet-id to detach. Providing Droplet ID is as of April 4th, 2017 required and it's not possible to detach without anymore.
detach-by-droplet-id is long for a function and makes its usage inconvenient.

This PR also regenerates mocks as it was forgotten in #208.

cc @mauricio @hugocorbucci @mchitten @magicgrl111

@mauricio
Copy link
Contributor

@xmudrii I think we're better off having detach and detach-by-droplet-id both for now and just print a deprecation warning when detach-by-droplet-id gets called so people have some time to update.

@xmudrii
Copy link
Contributor Author

xmudrii commented Apr 26, 2017 via email

@mauricio
Copy link
Contributor

We can just include deprecated at the description.

@xmudrii
Copy link
Contributor Author

xmudrii commented Apr 27, 2017

@mauricio is it good this way? 💯

@mauricio
Copy link
Contributor

I think we should instruct people to use detach, so instead of just (depecated) use (deprecated - use detach instead).

@xmudrii
Copy link
Contributor Author

xmudrii commented Apr 27, 2017

@mauricio yep, I agree. Change pushed 😄

@xmudrii
Copy link
Contributor Author

xmudrii commented Apr 27, 2017

@mauricio travis failed on tip for unknown reason. can you restart build?

@joonas
Copy link
Contributor

joonas commented Apr 27, 2017

@mauricio travis failed on tip for unknown reason. can you restart build?

I've gone ahead and restarted the build, looks like we're back to 💚

@mauricio mauricio merged commit a3b7b15 into digitalocean:master Apr 27, 2017
@xmudrii
Copy link
Contributor Author

xmudrii commented Apr 27, 2017

@mauricio @joonas Can confirm, it's green now, thanks for restarting 💚 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants