refactor/fix(DataStores): move instantiating of store related classes into their date stores #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into the relevant create methods and fixed FetchMemberOptions
…avoid the client property being undefined
bdistin
reviewed
Sep 1, 2017
src/stores/ChannelStore.js
Outdated
| constructor(iterable, options = {}) { | ||
| super(iterable); | ||
| constructor(client, options = {}) { | ||
| super(client); |
There was a problem hiding this comment.
Doesn't this remove the option of passing in an iterable? Not that I know a use case specifically where it would be needed, but all other stores can handle iterables being passed in.
There was a problem hiding this comment.
It wasn't possible previously, I just renamed the variable.
I'll add this either way, since all other stores are offering it.
* such presence many good * Update PresenceStore.js * Update index.js * Update ClientPresenceStore.js * Update Presence.js * Update ClientPresenceStore.js * Update ClientUser.js * Update Presence.js * add timestamps and party * Update Presence.js * Update PresenceStore.js * Update ClientPresenceStore.js * Update ClientPresenceStore.js
…1875) * fix: made options.type optional in ClientUser#setActivity * some changes, smol fix due to too many types being possible, it should just be defaulted to 0. this means streamers will have to set the type manually, though. also mistake with activity.name check
Since the return value of Collection#exists is basically just a boolean of Collection#find's result, the same documentation and arguments can and should be applied.
… into the relevant create methods and fixed FetchMemberOptions
…avoid the client property being undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Data Store:
clientproperty in theDataStore's constructor before iterating the eventual passed iterable to avoid the client property being undefined when executingcreate.(Guild)Channel Store:
Channel#createover instantiating in Channel Stores / any other files.ChannelStore's iterable parameter in the constructor is actually aClient, renamed for clarity.iterableparameter.GuildMember Store:
FetchMemberOptions#user)GuildMemberStoreas public class soGuildMemberStore#fetchcan be found in the docs.GuildMemberStore#_fetchManynow rejects with the intended error message, rather then its key.GuildMemberStore#_fetchManynow resolves when the limit of fetched members is reached or the full member count has been reached.RegardingGuildMemberStore#_fetchMany:How is fetching with a limit / query expected to work?
Fetching with a limit of 1000 fetches those 1000 but doesn't resolve the promies, which will time out and reject then.
The condition seems off here sincemembers.sizewill (or should) never be< 1000.See DiscordAPI docs:
up to 1000 members per chunk(My bad, > and < are hard to read :^))I am not sure how to fix this.Semantic versioning classification: