docs(Collection): Adjust exists documentation #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the return value of Collection#exists is basically just a boolean of Collection#find's result, the same documentation and arguments can and should be applied.
1Computer1
approved these changes
Sep 3, 2017
iCrawl
pushed a commit
that referenced
this pull request
Sep 3, 2017
… into their date stores (#1869) * refactor/fix(DataStores): move instantiating of store related classes into the relevant create methods and fixed FetchMemberOptions * Renamed ChannelStore's constructor parameter for claritiy * define client property before creating items from passed iterable to avoid the client property being undefined * Fix fetching members with a limit * add static Channel#create back and moved channel instantiating there * make ChannelStore's constructor accept an iterable * make iterable an optional parameter, allow to just pass client and options * fixed a little typo in docs of <User>.displayAvatarURL() (#1872) * Rewrite presence a little bit (#1853) * such presence many good * Update PresenceStore.js * Update index.js * Update ClientPresenceStore.js * Update Presence.js * Update ClientPresenceStore.js * Update ClientUser.js * Update Presence.js * add timestamps and party * Update Presence.js * Update PresenceStore.js * Update ClientPresenceStore.js * Update ClientPresenceStore.js * fix: made options.type optional in ClientUser#setActivity (#1875) * fix: made options.type optional in ClientUser#setActivity * some changes, smol fix due to too many types being possible, it should just be defaulted to 0. this means streamers will have to set the type manually, though. also mistake with activity.name check * docs(Collection): Adjust exists documentation (#1876) Since the return value of Collection#exists is basically just a boolean of Collection#find's result, the same documentation and arguments can and should be applied. * refactor(Emoji): remove Guild#deleteEmoji in favour of Emoji#delete (#1877) * refactor/fix(DataStores): move instantiating of store related classes into the relevant create methods and fixed FetchMemberOptions * Renamed ChannelStore's constructor parameter for claritiy * define client property before creating items from passed iterable to avoid the client property being undefined * Fix fetching members with a limit * add static Channel#create back and moved channel instantiating there * make ChannelStore's constructor accept an iterable * make iterable an optional parameter, allow to just pass client and options * rebase, this time with saving the file * address issue with falsy activity throwing errors when setting client's presence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Since the return value of Collection#exists is basically just a boolean of Collection#find's result, the same documentation and arguments can and should be applied.
Also, note for semantic classification: While my commit does rename one of the method parameters as part of the documentation adjustment, the functionality is exactly the same. This is why I have marked it as doc change and not interface change.
Semantic versioning classification: