-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for CUSTOM_STATUS activity type #3353
feat: support for CUSTOM_STATUS activity type #3353
Conversation
Bumping this up as custom status is landing now |
The PR is incomplete @favna, see discord/discord-api-docs#1160 (comment) Maybe it's time to add these too? |
I have you tested this manually through the API? Seems like it is not covered for Bot use as of right now. |
@fatplatapus that's correct it's not available for bots but that doesn't stop bots from getting this data for regular users. Ergo you see the image of A good remark but note that it is also covered in the referenced issue on discordapp/discord-api-docs. |
@favna Ah ok! Didn't realize this was for getting a user's custom status. Looking over code now, looks good! Nice job :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stop spamming peoples notifications with this, if you want to use this just run the fork instead of original d.js in your bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A getter for Activity#createdAt (which simply returns new Date(this.createdTimestamp)
) should be added for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gg
@JMTK That is not part of this pull request and falls out-of-scope. You can create your own pull request to cover such a feature if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cant wait for this custom status update for bots. all checks passed dev ?
@RootAndroid58 this will not allow bots to set custom status. Bots cannot have a custom status by API limitation. This will only allow bots to read the custom status of users. And yes as you can clearly see all checks have passed. This PR is waiting for someone like @SpaceEEC to review it. |
* feat: support for custom status in activity * nit(typings): order properties
…ordjs#3353)" This reverts commit 5b43ddc.
Please describe the changes this PR makes and why it should be merged:
This PR covers the custom status Discord recently released to the public. The PR was initially created 4 months ago based on data mined data but now that custom statuses are in the public the PR should enter the merge track.
Evals performed with code changes:
Original post from 4 months ago:
This is an upcoming feature that has been data mined from the Canary client. Presumably these few lines are all that is needed since in ClientPresence the number gets matched to the indexOf the ActivityType constant and the new options are as follows:
Example images after enabling the option, courtesy of a friend of mine who has it as I do not have it myself.
As an aside, there also seems to be an upcoming custom voice status however there is not sufficient enough information for that yet to suggest any code changes. That said, I can guarantee my friend and I will keep our eyes out and I'll be back with another PR if required for that.
Status
Semantic versioning classification: