Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Presence/Game): multiple activities and custom status #3747

Merged
merged 2 commits into from
Feb 1, 2020

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Jan 25, 2020

Please describe the changes this PR makes and why it should be merged:

This PR backports #3661 and #3703 by adding support for multiple activities.
This PR also backports #3353 by adding emoji, createdAt, and createdTimestamp to Game.

I removed the duplicated code in Presence by putting the initializing part into the update method.

The hack using MessageReaction is a bit ugly, but I couldn't come up with anything better.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC merged commit 17b8b23 into discordjs:11.5-dev Feb 1, 2020
@SpaceEEC SpaceEEC deleted the feat/presence_activities branch February 1, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant