suites: simplify code

[blaggacao]

If this code had been written this way, I wouldn't have opened #200 in
the first place. (perspective of a begginer nix-langer)

closes: #200 This is a pre-fix to PR #202

[Pacman99]

This makes defining suites much more complex. You have to call profileMap at the front of every suite.

[blaggacao]

This makes defining suites much more complex. You have to call profileMap at the front of every suite.

But at least I do understand what I'm actually doing 😉

profileMap implements the receiving end of the fs layout contract. Now everything is clear by analogy / parallelism with allProfiles & allUsers.

[blaggacao]

bors try

[bors]

try

Already running a review

[blaggacao]

bors try-

I think I still don't understand what this code does.

[Pacman99]

profileMap implements the receiving end of the fs layout contract. Now everything is clear by analogy / parallelism with allProfiles & allUsers.

I think proper ux and a stable api is more important than an analogy being correct. And having users run a function on every suite manually, imo, is a step backwards. And if you just look down at the mapAttrs, you would see that profileMap is run at every function. So I really don't see what this PR accomplishes.

[blaggacao]

ping, made a change.

The commit message has the impetus (me in abstractable role of nix beginner trying to understand what's going on).

I think I still don't understand what this code does.

I think this is still true. ❓

[blaggacao]

bors try

[bors]

try

Timed out.