Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core #276

Merged
merged 107 commits into from
May 15, 2021
Merged

Update core #276

merged 107 commits into from
May 15, 2021

Conversation

Pacman99
Copy link
Member

@Pacman99 Pacman99 commented May 6, 2021

Core is starting to get pretty stale. All the changes in develop are pretty stable and I think we should encourage updating to them. As most future updates can be done through devlib, so once you switch to this version of the template. Updating to new changes will be much simpler (ie #91).

Pacman99 and others added 30 commits April 11, 2021 20:09
Update evalArgs to match the new planned API
for clarity's sake, expose which function uses final and prev, so that
people can have a clearer understanding how they relate to each other
in terms of dependencies.

also a simple `{ lib = final; }` probably does not warrant a complete
callLibs obscurization.
Intermediate version of api-next
allow lists, nested lists, and non-lists for list like options
drop config.<name>.externalModules
used coercedTo for typing and improve options
in devos, we differentiate clearly between home and os
configuration, reason for which we are more precise by not naming
after the (more generic) fup API.
ref: config -> hosts | nixos -> os
fix pathTo and coercedList types
add modulesModule to also include modules option under home
Also format all files and add a flake.lock for lib
for a folder thats meant to work on other flakes theres never a reason
it should need to refer to itself, only other flakes. So "self" and
"inputs" are better namings for these variables. The userFlake* is
redundant and confusing, when trying to call the functions its hard to
figure out how to use them when there are now two lines of arguments to
figure out.
@Pacman99
Copy link
Member Author

Both pathsIn and importHosts are a little bit of (excess) black magic that makes one feel uncertain about what's going on, when reading the flake. I'm not convinced, wether they are the right level of abstraction, here, at the flake.nix level.

I think auto-importing should be done in flake.nix as much as possible. I don't like hiding inside evalArgs because then you can't remove it or change it easily. I would argue that hiding it is more black magic and its even worse since its hidden.

I like this method, since its clear where auto-importing is happening and anyone that isn't a fan can just remove those lines. and use import instead.

The only exception to me is profiles but thats ok since its an argument that is always auto-imported.

Pacman99 added 4 commits May 11, 2021 11:40
drop ca experimental features and filterPackages improvements
includes ability to customize shell from template
flake.nix Outdated Show resolved Hide resolved
Pacman99 added 2 commits May 13, 2021 16:59
includes nixos option improvements and importHosts change
This makes the auto-importing of hosts obvious and explicitly indicates
how the options would end up getting merged.
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@Pacman99
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 14, 2021
@bors
Copy link
Contributor

bors bot commented May 14, 2021

try

Build succeeded:

Copy link
Contributor

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flush.

@divnix divnix deleted a comment from bors bot May 15, 2021
@blaggacao
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented May 15, 2021

Build succeeded:

@bors bors bot merged commit 4df3d8c into core May 15, 2021
@bors bors bot deleted the develop branch May 15, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants