Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs-lib/shell: sudo nixos-generate-config #281

Closed
wants to merge 1 commit into from
Closed

Conversation

bb010g
Copy link
Contributor

@bb010g bb010g commented May 15, 2021

$ btrfs subvol show / >/dev/null; printf "%s\n" "$?"
ERROR: Could not search B-tree: Operation not permitted
1

Btrfs's ioctl() BTRFS_IOC_TREE_SEARCH requires elevation. btrfs subvol show <path> may be called by nixos-generate-config, and if btrfs subvol show <path> fails then nixos-generate-config fails.

```
$ btrfs subvol show / >/dev/null; printf "%s\n" "$?"
ERROR: Could not search B-tree: Operation not permitted
1
```

Btrfs's `ioctl()` `BTRFS_IOC_TREE_SEARCH` requires elevation.
`btrfs subvol show <path>` may be called by `nixos-generate-config`, and
if `btrfs subvol show <path>` fails then `nixos-generate-config` fails.
@Pacman99
Copy link
Member

Pacman99 commented May 15, 2021

Thanks for the PR! That sounds good to me.

We are actually in the process of completely moving the devos library to https://github.com/divnix/digga. So your change won't have any affect after #276 is merged.

It would be great if you could switch your PR to target digga instead. It should be the same idea except the change would have to go in src/pkgs-lib/shell.

@bb010g
Copy link
Contributor Author

bb010g commented May 15, 2021

If #276 will cause core to be based off of up-to-date digga, then could this still be merged to core here as a backport?

@blaggacao
Copy link
Contributor

blaggacao commented May 15, 2021

develop is probably going to be merged into core in a matter of minutes, so we are on kind of an implicit "freeze" on core at the moment.

@Pacman99
Copy link
Member

your fix just made it in 634cfcb

Thank you :)

@Pacman99 Pacman99 closed this May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants