feat(charts): Update Victory dependencies

patternfly#7614
dlabrecq · Jul 8, 2022 · 1c40189 · 1c40189
1 parent 04d698f
commit 1c40189
Show file tree

Hide file tree

Showing 4 changed files with 313 additions and 190 deletions.
diff --git a/packages/react-charts/package.json b/packages/react-charts/package.json
@@ -34,21 +34,21 @@
     "hoist-non-react-statics": "^3.3.0",
     "lodash": "^4.17.19",
     "tslib": "^2.0.0",
-    "victory-area": "^36.2.1",
-    "victory-axis": "^36.2.1",
-    "victory-bar": "^36.2.1",
-    "victory-chart": "^36.2.1",
-    "victory-core": "^36.2.1",
-    "victory-create-container": "^36.2.1",
-    "victory-group": "^36.2.1",
-    "victory-legend": "^36.2.1",
-    "victory-line": "^36.2.1",
-    "victory-pie": "^36.2.1",
-    "victory-scatter": "^36.2.1",
-    "victory-stack": "^36.2.1",
-    "victory-tooltip": "^36.2.1",
-    "victory-voronoi-container": "^36.2.1",
-    "victory-zoom-container": "^36.2.1"
+    "victory-area": "^36.5.3",
+    "victory-axis": "^36.5.3",
+    "victory-bar": "^36.5.3",
+    "victory-chart": "^36.5.3",
+    "victory-core": "^36.5.3",
+    "victory-create-container": "^36.5.3",
+    "victory-group": "^36.5.3",
+    "victory-legend": "^36.5.3",
+    "victory-line": "^36.5.3",
+    "victory-pie": "^36.5.3",
+    "victory-scatter": "^36.5.3",
+    "victory-stack": "^36.5.3",
+    "victory-tooltip": "^36.5.3",
+    "victory-voronoi-container": "^36.5.3",
+    "victory-zoom-container": "^36.5.3"
   },
   "peerDependencies": {
     "react": "^16.8.0 || ^17.0.0",

diff --git a/packages/react-charts/src/components/ChartLine/ChartLine.tsx b/packages/react-charts/src/components/ChartLine/ChartLine.tsx
@@ -1,7 +1,6 @@
 import * as React from 'react';
 import hoistNonReactStatics from 'hoist-non-react-statics';
 import {
-  AnimatePropTypeInterface,
   CategoryPropType,
   D3Scale,
   DataGetterPropType,
@@ -43,11 +42,10 @@ export interface ChartLineProps extends VictoryLineProps {
    * The animate prop should also be used to specify enter and exit
    * transition configurations with the `onExit` and `onEnter` namespaces respectively.
    *
-   * @propType boolean | object
    * @example
    * {duration: 500, onExit: () => {}, onEnter: {duration: 500, before: () => ({y: 0})})}
    */
-  animate?: boolean | AnimatePropTypeInterface;
+  animate?: boolean;
   /**
    * The categories prop specifies how categorical data for a chart should be ordered.
    * This prop should be given as an array of string values, or an object with
@@ -346,8 +344,10 @@ export interface ChartLineProps extends VictoryLineProps {
    * Use the sortKey prop to indicate how data should be sorted. This prop
    * is given directly to the lodash sortBy function to be executed on the
    * final dataset.
+   *
+   * @propType string | string[] | number | number[]
    */
-  sortKey?: string | string[] | Function;
+  sortKey?: DataGetterPropType;
   /**
    * The sortOrder prop specifies whether sorted data should be returned in 'ascending' or 'descending' order.
    *

diff --git a/packages/react-charts/src/components/ChartThreshold/ChartThreshold.tsx b/packages/react-charts/src/components/ChartThreshold/ChartThreshold.tsx
@@ -2,7 +2,6 @@ import * as React from 'react';
 import hoistNonReactStatics from 'hoist-non-react-statics';
 import cloneDeep from 'lodash/cloneDeep';
 import {
-  AnimatePropTypeInterface,
   CategoryPropType,
   D3Scale,
   DataGetterPropType,
@@ -36,11 +35,11 @@ export interface ChartThresholdProps extends VictoryLineProps {
    * The animate prop should also be used to specify enter and exit
    * transition configurations with the `onExit` and `onEnter` namespaces respectively.
    *
-   * @propType boolean | object
+   * @propType boolean
    * @example
    * {duration: 500, onExit: () => {}, onEnter: {duration: 500, before: () => ({y: 0})})}
    */
-  animate?: boolean | AnimatePropTypeInterface;
+  animate?: boolean;
   /**
    * The categories prop specifies how categorical data for a chart should be ordered.
    * This prop should be given as an array of string values, or an object with
@@ -339,8 +338,10 @@ export interface ChartThresholdProps extends VictoryLineProps {
    * Use the sortKey prop to indicate how data should be sorted. This prop
    * is given directly to the lodash sortBy function to be executed on the
    * final dataset.
+   *
+   * @propType string | string[] | number | number[]
    */
-  sortKey?: string | string[] | Function;
+  sortKey?: DataGetterPropType;
   /**
    * The sortOrder prop specifies whether sorted data should be returned in 'ascending' or 'descending' order.
    *