-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charts: Update Victory dependencies #7614
Comments
@dlabrecq do you see any issues with this? |
Should be ok, but I'd like to test this with Cost Management. I had some trouble updating to the latest packages recently. |
There appears to be a lot of TypeScript changes for v36.5.1 and later. Looking at some of the changes in v36.5.3, I suspect there is more to come? |
Encountered a type error with Victory, which prevents me from building PatternFly. I was able to resolve the error, but it requires PatternFly to update to TypeScript v4.7.3 Created issue #7662 |
I've updated our dependencies via PR #7674. However, waiting for Victory to fix the TypeScript error above. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I pushed a fix to the Victory upstream |
This PR updates Victory dependencies to v36.6.7 |
Please update the Victory dependencies to at least 36.5.1 as it fixes an annoying bug in build, see FormidableLabs/victory#2307.
Currently, I get a million warnings messages like the following when trying to build a Patternfly app:
The text was updated successfully, but these errors were encountered: