Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Update Victory dependencies #7614

Closed
mgrabovsky opened this issue Jun 27, 2022 · 10 comments · Fixed by #7986
Closed

Charts: Update Victory dependencies #7614

mgrabovsky opened this issue Jun 27, 2022 · 10 comments · Fixed by #7986
Assignees
Labels

Comments

@mgrabovsky
Copy link

Please update the Victory dependencies to at least 36.5.1 as it fixes an annoying bug in build, see FormidableLabs/victory#2307.

Currently, I get a million warnings messages like the following when trying to build a Patternfly app:

Failed to parse source map from '/www/node_modules/victory-area/es/area.js.map' file: Error: ENOENT: no such file or directory, open '/www/node_modules/victory-area/es/area.js.map'
@nicolethoen
Copy link
Contributor

@dlabrecq do you see any issues with this?

@dlabrecq
Copy link
Member

dlabrecq commented Jul 6, 2022

Should be ok, but I'd like to test this with Cost Management. I had some trouble updating to the latest packages recently.

@dlabrecq dlabrecq self-assigned this Jul 6, 2022
@dlabrecq
Copy link
Member

dlabrecq commented Jul 6, 2022

There appears to be a lot of TypeScript changes for v36.5.1 and later. Looking at some of the changes in v36.5.3, I suspect there is more to come?

@dlabrecq
Copy link
Member

dlabrecq commented Jul 6, 2022

Encountered a type error with Victory, which prevents me from building PatternFly. I was able to resolve the error, but it requires PatternFly to update to TypeScript v4.7.3

Screen Shot 2022-07-06 at 12 57 26 PM

Created issue #7662

@dlabrecq dlabrecq changed the title Charts - Update Victory dependencies Charts: Update Victory dependencies Jul 7, 2022
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 8, 2022
@dlabrecq
Copy link
Member

dlabrecq commented Jul 8, 2022

I've updated our dependencies via PR #7674.

However, waiting for Victory to fix the TypeScript error above.

@nicolethoen nicolethoen moved this to In Progress in PatternFly Issues Jul 19, 2022
@stale
Copy link

stale bot commented Sep 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Sep 9, 2022
@mgrabovsky
Copy link
Author

@dlabrecq What is the current status here, please? It looks like #7674 was closed without merging with no follow-up.

@stale stale bot removed the wontfix label Sep 11, 2022
@dlabrecq
Copy link
Member

dlabrecq commented Sep 12, 2022

Unfortunately, I encountered a Type error that must be fixed in the Victory upstream. The animate prop should accept a boolean or object. It would be incorrect to change the type to accept a boolean only.

Screen Shot 2022-09-12 at 1 20 32 PM

@dlabrecq
Copy link
Member

dlabrecq commented Sep 14, 2022

I pushed a fix to the Victory upstream https://github.com/FormidableLabs/victory/pull/2464.
Waiting for the next release.

dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Sep 15, 2022
@dlabrecq
Copy link
Member

This PR updates Victory dependencies to v36.6.7

#7986

dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Sep 15, 2022
Repository owner moved this from In Progress to Done in PatternFly Issues Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants