Merge pull request nanograv#1702 from abhisrkckl/validation

Component validation for WaveX and DMWaveX

CHANGELOG-unreleased.md

@@ -36,7 +36,8 @@ the released changes.
 - Fixed `derived_params` when OMDOT has 0 uncertainty
 - `model.find_empty_masks` will now also look at DMX and SWX parameters
 - Fixed `make_fake_toas_fromtim`
-- Better exceptions for unsupported/unimplemented binary models (BTX, MSS, etc.)
 - Use `Hessian` instead of `Hessdiag` in `DownhillFitter._fit_noise`; compute noise parameter uncertainties only once in `DownhillFitter.fit_toas`.
 - Consistent naming in `TimingModel.get_params_mapping()`
+- Better exceptions for unsupported/unimplemented binary models (BTX, MSS, etc.)
+- Emit warnings when `WaveX`/`DMWaveX` is used together with other representations of red/DM noise
 ### Removed

src/pint/models/timing_model.py

@@ -491,15 +491,19 @@ def num_components_of_type(type):
 
         from pint.models.dispersion_model import DispersionDMX
         from pint.models.wave import Wave
+        from pint.models.wavex import WaveX
+        from pint.models.dmwavex import DMWaveX
         from pint.models.noise_model import PLRedNoise, PLDMNoise
 
-        if num_components_of_type((DispersionDMX, PLDMNoise)) > 1:
+        if num_components_of_type((DispersionDMX, PLDMNoise, DMWaveX)) > 1:
             log.warning(
-                "DispersionDMX and PLDMNoise are being used together. They are two ways of modelling the same effect."
+                "DispersionDMX, PLDMNoise, and DMWaveX cannot be used together. "
+                "They are ways of modelling the same effect."
             )
-        if num_components_of_type((Wave, PLRedNoise)) > 1:
+        if num_components_of_type((Wave, WaveX, PLRedNoise)) > 1:
             log.warning(
-                "Wave and PLRedNoise are being used together. They are two ways of modelling the same effect."
+                "Wave, WaveX, and PLRedNoise cannot be used together. "
+                "They are ways of modelling the same effect."
             )
 
     # def __str__(self):