Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In lint check, disallow std::regex since it's not supported by GCC 4.8.x #3870

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Nov 6, 2018

Make sure that any new pull request does not use std::regex. Although std::regex is part of C++11, GCC 4.8.x does not support it. (GCC 4.8.x is used to build Python wheels for the sake for maximum portability.)

@codecov-io
Copy link

Codecov Report

Merging #3870 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3870      +/-   ##
============================================
- Coverage     51.95%   51.95%   -0.01%     
  Complexity      203      203              
============================================
  Files           182      182              
  Lines         14500    14500              
  Branches        495      495              
============================================
- Hits           7534     7533       -1     
- Misses         6728     6729       +1     
  Partials        238      238
Impacted Files Coverage Δ Complexity Δ
src/objective/multiclass_obj.cu 92.7% <0%> (-1.05%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1698fe6...1a4c47a. Read the comment docs.

@hcho3 hcho3 merged commit 20d5abf into dmlc:master Nov 6, 2018
@hcho3 hcho3 deleted the dont-use-regex branch November 6, 2018 06:57
@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants