Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In lint check, disallow std::regex since it's not supported by GCC 4.8.x #3870

Merged
merged 1 commit into from
Nov 6, 2018
Merged

In lint check, disallow std::regex since it's not supported by GCC 4.8.x #3870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/travis/run_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ if [ ${TASK} == "lint" ]; then
# Fail only on warnings related to XGBoost source files
(cat logtidy.txt|grep -E 'xgboost.*warning'|grep -v dmlc-core) && exit -1
echo "----------------------------"

if grep -R '<regex>' src include tests/cpp plugin jvm-packages amalgamation; then
echo 'Do not use std::regex, since it is not supported by GCC 4.8.x'
exit -1
fi

exit 0
fi

Expand Down