This repository has been archived by the owner on Jun 16, 2021. It is now read-only.
Carry #358 — Validate compose v2 input #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vdemeester awesome work, I could not keep it going due to lack of understanding in that part of code! |
Compose v1 has input validation but in the composev2 merge function validation was missing so added it. Fixes docker#357 Signed-off-by: Suraj Deshmukh <[email protected]> Signed-off-by: Vincent Demeester <[email protected]>
cdrage
added a commit
to cdrage/kompose
that referenced
this pull request
Jan 3, 2017
This commit updates libcompose in order to merge in docker/libcompose#423 which affected kubernetes#92 by not erroring out when an image name wasn't provided. Closes kubernetes#92 As well as knocks out the last required milestone for a 0.2.1 release https://github.com/kubernetes-incubator/kompose/milestone/2
cdrage
added a commit
to cdrage/kompose
that referenced
this pull request
Jan 4, 2017
This commit updates libcompose in order to merge in docker/libcompose#423 which affected kubernetes#92 by not erroring out when an image name wasn't provided. Closes kubernetes#92 As well as knocks out the last required milestone for a 0.2.1 release https://github.com/kubernetes-incubator/kompose/milestone/2
kadel
pushed a commit
to kadel/kompose
that referenced
this pull request
Jan 20, 2017
This commit updates libcompose in order to merge in docker/libcompose#423 which affected kubernetes#92 by not erroring out when an image name wasn't provided. Closes kubernetes#92 As well as knocks out the last required milestone for a 0.2.1 release https://github.com/kubernetes-incubator/kompose/milestone/2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carry and closes #358
/cc @joshwget @surajssd
Compose v1 has input validation but in the composev2
merge function validation was missing so added it.
Fixes #357
Signed-off-by: Suraj Deshmukh [email protected]