Image name not given still kompose does not errors out

[surajssd]

Using docker-compose file that has no field for image, so this should error out, but this still works.

$ cat /tmp/docker-compose-no-image.yml 
version: "2"

services:
  mariadb:
    ports:
      - 3306

output

$ kompose convert --stdout -y -f /tmp/docker-compose-no-image.yml                                                                                                                       
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: null
  labels:
    service: mariadb
  name: mariadb
spec:
  ports:
  - name: "3306"
    port: 3306
    protocol: TCP
    targetPort: 3306
  selector:
    service: mariadb
status:
  loadBalancer: {}

---
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    service: mariadb
  name: mariadb
spec:
  replicas: 1
  selector:
    matchLabels:
      service: mariadb
  strategy: {}
  template:
    metadata:
      creationTimestamp: null
      labels:
        service: mariadb
    spec:
      containers:
      - name: mariadb
        ports:
        - containerPort: 3306
          protocol: TCP
        resources: {}
      restartPolicy: Always
status: {}

---

[sebgoa]

is there a way to validate the docker-compose file with lib compose ?

[ngtuna]

@Runseb : docker-compose has this validation. libcompose should have.

$ cat docker-compose.yml
web:
  links:
   - redis
redis:

$ docker-compose up
ERROR: The Compose file is invalid because:
Service web has neither an image nor a build context specified. At least one must be provided.

[ngtuna]

Found it.
https://github.com/docker/libcompose/blob/master/config/validation.go#L263

@surajssd you will see kompose currently use function Parse() of libcompose in order to read compose file. It should then call to validateServiceConstraints() above.

[surajssd]

@ngtuna thanks for that pointer :-)

[surajssd]

@ngtuna now when I started working on this, looks like function validateServiceConstraints is not exported so, we might need different way to validate the values.

[surajssd]

Also with libcompose I found this thing:

[vagrant@fedora tmp]$ cat docker-compose.yml 
version: "2"

services:
  mariadb:
    ports:
      - 3306

somehow the docker-compose warning is not what I get

[vagrant@fedora tmp]$ libcompose up
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose) 
INFO[0000] [0/1] [mariadb]: Starting                    
ERRO[0000] Failed Starting mariadb : Error: No such image: tmp_mariadb 
ERRO[0000] Failed to start: mariadb : Error: No such image: tmp_mariadb 
Error: No such image: tmp_mariadb

Using following libcompose version

$ libcompose version
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose) 
Version:      0.3.0-dev (HEAD)
Go version:   go1.6.3

It didn't tell me that I have not put image name!

[surajssd]

But for a docker-compose file of v1 like this

[vagrant@fedora tmp]$ cat docker-compose.yml
mariadb:
  ports:
    - 3306

I get errors similar to docker-compose

[vagrant@fedora tmp]$ libcompose up
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose) 
ERRO[0000] Could not parse config for project tmp : Service 'mariadb' has neither an image nor a build path specified. Exactly one must be provided. 
FATA[0000] Failed to read project: Service 'mariadb' has neither an image nor a build path specified. Exactly one must be provided.

[surajssd]

Filed issue in libcompose docker/libcompose#357

[sebgoa]

@surajssd @ngtuna looks like lib compose now got validation for v2 docker/libcompose#371

We should try to close this.

[ngtuna]

Well yeah, upgrade libcompose will help solving couple of problems.
Hey @kadel , I could help to do that while you are taking care of k8s go client.

[kadel]

@ngtuna sure, go ahead

[ngtuna]

closed via #195

[surajssd]

@ngtuna this is issue is not fixed yet!

[surajssd]

docker-compose file

$ cat docker-compose-no-image.yml 
version: "2"

services:
  mariadb:
    ports:
      - 3306

  etherpad:
    ports:
      - "80:9001"

output

$ kompose -f docker-compose-no-image.yml convert --stdout -y
apiVersion: v1
items:
- apiVersion: v1
  kind: Service
[SNIP]
    loadBalancer: {}
- apiVersion: extensions/v1beta1
  kind: Deployment
  metadata:
    creationTimestamp: null
    name: mariadb
  spec:
    replicas: 1
    strategy: {}
    template:
      metadata:
        creationTimestamp: null
        labels:
          service: mariadb
      spec:
        containers:
        - name: mariadb
          ports:
          - containerPort: 3306
            protocol: TCP
          resources: {}
        restartPolicy: Always
  status: {}
- apiVersion: extensions/v1beta1
  kind: Deployment
  metadata:
    creationTimestamp: null
    name: etherpad
  spec:
    replicas: 1
    strategy: {}
    template:
      metadata:
        creationTimestamp: null
        labels:
          service: etherpad
      spec:
        containers:
        - name: etherpad
          ports:
          - containerPort: 9001
            protocol: TCP
          resources: {}
        restartPolicy: Always
  status: {}
kind: List
metadata: {}

[ngtuna]

Oh you're right. Thanks @surajssd good catch. If that's compose version 1, kompose worked. But it seems does not work on version 2. Let me check.

[sebgoa]

@ngtuna any news on this.

[ngtuna]

@sebgoa it's still there. Just tested with libcompose HEAD. Let me just tackling it directly without libcompose.

[ngtuna]

This issue just be solved in libcompose docker/libcompose#415. Will check that piece of code shortly.