Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

Update VMware Fusion and vSphere driver to run boot2docker 1.6.0 #1034

Merged
merged 1 commit into from
Apr 21, 2015
Merged

Update VMware Fusion and vSphere driver to run boot2docker 1.6.0 #1034

merged 1 commit into from
Apr 21, 2015

Conversation

frapposelli
Copy link
Contributor

  • Update custom ISO to docker 1.6.0.
  • Shared folder support for VMware Fusion.
  • Updated bats test for Fusion.
$ bats test/integration/driver-vmwarefusion.bats
 ✓ vmwarefusion: docker-machine should not exist
 ✓ vmwarefusion: create
 ✓ vmwarefusion: active
 ✓ vmwarefusion: ls
 ✓ vmwarefusion: run busybox container
 ✓ vmwarefusion: url
 ✓ vmwarefusion: ip
 ✓ vmwarefusion: ssh
 ✓ vmwarefusion: stop
 ✓ vmwarefusion: docker-machine should show stopped after stop
 ✓ vmwarefusion: start
 ✓ vmwarefusion: docker-machine should show running after start
 ✓ vmwarefusion: kill
 ✓ vmwarefusion: docker-machine should show stopped after kill
 ✓ vmwarefusion: restart
 ✓ vmwarefusion: docker-machine should show running after restart
 ✓ vmwarefusion: remove
 ✓ vmwarefusion: docker-machine should not exist
 ✓ vmwarefusion: cleanup

19 tests, 0 failures

Fixes #1021 #1020 #641 #532 #430

@frapposelli
Update VMware Fusion and vSphere driver to run boot2docker 1.6.0
25583ed 
- Update custom ISO to docker 1.6.0.
- Shared folder support for VMware Fusion.
- Updated bats test for Fusion.

Signed-off-by: Fabio Rapposelli <[email protected]>
This was referenced Apr 21, 2015
Closed
Closed
Closed
@dansowter
Copy link

Boom!! Thanks @frapposelli

@frapposelli frapposelli mentioned this pull request Apr 21, 2015
Closed
@meangrape
Copy link

Thanks!

@cmoro-deusto
Copy link

Awesome! Thank you @frapposelli

@Maxim-Filimonov
Copy link

@frapposelli Thanks! Just curious is it faster than NFS?

@frapposelli
Copy link
Contributor Author

@Maxim-Filimonov not always faster than NFS, @mitchellh has done an interesting analysis of the various sync options with local hypervisors here http://mitchellh.com/comparing-filesystem-performance-in-virtual-machines

@ehazlett
Copy link
Contributor

LGTM 👍

ehazlett added a commit that referenced this pull request Apr 21, 2015
@ehazlett
Merge pull request #1034 from frapposelli/fusion-shared-folders
f64eb09 
Update VMware Fusion and vSphere driver to run boot2docker 1.6.0
@ehazlett ehazlett merged commit f64eb09 into docker:master Apr 21, 2015
@frapposelli frapposelli deleted the fusion-shared-folders branch April 21, 2015 14:36
@idyll idyll mentioned this pull request Apr 22, 2015
Closed
@philm
Copy link

philm commented Apr 22, 2015

Thanks - this is rad! The performance of VMware Fusion shared volumes is great, even with fairly sizable projects. I've ditched my Vagrant boot2docker/NFS setup in my dev environment for the time being, and I'm also able to use docker-machine's interface to a larger extent.

After creating my VM with docker-machine, I went into Fusion's GUI and tweaked a few more things. For example, the processor was set to 4 cores - I'm on a 2 core machine (Fusion displayed a performance warning in that section). I also went to the Hard Disk section and pre-allocated the disk.

@ehazlett
Copy link
Contributor

@philm thanks for the feedback!

@frapposelli i believe the default number of CPUs should default to the host system correct?

@FlxPeters FlxPeters mentioned this pull request Apr 27, 2015
Closed
miketheman added a commit to miketheman/machine that referenced this pull request May 21, 2015
@miketheman
Convert vmwarefusion bats tests back to machine
f540f36 
In docker#615, the helper function `machine()` was created and used within the
vmwarefusion test suite (amongst others) to wrap a platform-specfic
binary during the test suite.

In docker#1034, it appears that this name was changed to the normal
docker-machine binary, which can incoke the system-installed one, not
the recently compiled one, potentially testing the incorrect binary.

See:
- docker#615 (comment)
- https://github.com/docker/machine/pull/1034/files#diff-62c88a2fede921556dbdeead731596b2R14
miketheman added a commit to miketheman/machine that referenced this pull request May 21, 2015
@miketheman
Convert vmwarefusion bats tests back to machine
cd049cb 
In docker#615, the helper function `machine()` was created and used within the
vmwarefusion test suite (amongst others) to wrap a platform-specfic
binary during the test suite.

In docker#1034, it appears that this name was changed to the normal
docker-machine binary, which can incoke the system-installed one, not
the recently compiled one, potentially testing the incorrect binary.

See:
- docker#615 (comment)
- https://github.com/docker/machine/pull/1034/files#diff-62c88a2fede921556dbdeead731596b2R14

Signed-off-by: Mike Fiedler <[email protected]>
tomeon pushed a commit to tomeon/machine that referenced this pull request May 9, 2018
@tianon
Merge pull request docker#1034 from gesellix/patch-1
1df8dc3 
use new 'daemon' command
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vmwarefusion driver errors with 'fail to create'
7 participants
@frapposelli @dansowter @meangrape @cmoro-deusto @Maxim-Filimonov @ehazlett @philm