Remove unused cache #2370
Closed
Remove unused cache #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2370 +/- ##
=========================================
Coverage 81.06% 81.06%
+ Complexity 3087 3086 -1
=========================================
Files 145 145
Lines 7905 7906 +1
=========================================
+ Hits 6408 6409 +1
Misses 1497 1497
Continue to review full report at Codecov.
|
1 task
|
Closing in favor of #2390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was taking a look at not using cache from metadata factory and bump into this.
It was added 56e4f69 because of #58. I guess that was added because at that time the key for storing metadata was created like that based on:
https://github.com/doctrine/orm/blob/b67d400e940b7bd0c99e37b2f6112f8dc1ac7710/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php#L165-L174
The way the key is generated has been changed lately when supporting PRS-6 because the cache key can't contain
\, so not sure if this is needed anymore.I'll try to see if I can find out if this is really needed, but since I don't use the extension any comment is appreciated.