Use Doctrine MetadataCache if a cache is not set #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2407 +/- ##
============================================
+ Coverage 80.47% 80.49% +0.01%
- Complexity 3152 3154 +2
============================================
Files 159 159
Lines 8160 8167 +7
============================================
+ Hits 6567 6574 +7
Misses 1593 1593
Continue to review full report at Codecov.
|
franmomu
force-pushed
the
use_doctrine_cache_fallback
branch
from
251a8af to
c0695aa
Compare
franmomu
force-pushed
the
use_doctrine_cache_fallback
branch
3 times, most recently
from
05bf050 to
ea05421
Compare
franmomu
force-pushed
the
use_doctrine_cache_fallback
branch
3 times, most recently
from
0da83b4 to
8305832
Compare
franmomu
force-pushed
the
use_doctrine_cache_fallback
branch
from
8305832 to
f105358
Compare
stof
reviewed
Jan 10, 2022
|
|
||
| $this->expectDeprecationWithIdentifier('https://github.com/doctrine/persistence/issues/184'); | ||
| } else { | ||
| $this->expectDeprecation('Doctrine\Persistence\Mapping\AbstractClassMetadataFactory::getCacheDriver is deprecated. Use getCache() instead.'); |
There was a problem hiding this comment.
why not use getCache instead of the deprecated API when it is available ?
There was a problem hiding this comment.
because AbstractClassMetadataFactory::getCache()is protected: https://github.com/doctrine/persistence/blob/f8af155c1e7963f3d2b4415097d55757bbaa53d8/lib/Doctrine/Persistence/Mapping/AbstractClassMetadataFactory.php#L119
phansys
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit concern about performance after #2373 because before that, the cache was shared among the listeners and now it should be set externally.
I've created stof/StofDoctrineExtensionsBundle#436 to try to solve it for the bundle.
In the meantime, instead of creating a new
ArrayAdapteras fallback, I think we can go back to doctrine metadata cache so everything should work as before.I'll try later today to add a test andafter this I'm fine releasing3.5.0.