Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Update the profiler panel for Symfony 6.2+ #1558

Closed
wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Contributor

This is still WIP. When it's ready for review I'll post some screenshots.

<span class="value">{{ collector.groupedQueryCount }}</span>
<span class="label">Different statements</span>
</div>
<div class="metric-group">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this markup work in Symfony 6.1 too ?

</div>
<div class="metric">
<span class="value">{{ collector.groupedQueryCount }}</span>
<span class="label">Statements</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous label was Different statements, and the key thing to distinguish it from the previous number is the word Different that you removed.

<span class="label">Puts</span>
</div>
<div class="tab">
<h3 class="tab-title">Connections & EM</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use &amp;

<p>Second level cache information is not available.</p>
</div>
{% else %}
<div class="metric-gro">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="metric-gro">
<div class="metric-group">

?

@ostrolucky
Copy link
Member

Sorry @javiereguiluz but this is open for too long with no traction. Let's reopen when you are ready to continue working on it, alright? :)

@ostrolucky ostrolucky closed this Dec 3, 2022
@derrabus derrabus removed this from the 2.8.0 milestone Dec 29, 2022
@nickygerritsen
Copy link

From the default profiler panes Doctrine is currently the only one that is not in the new style, which is most obvious looking at the sidebar:
image

What needs to happen to actually make this update? Maybe we can resurrect/recreate the PR? Or should we at least create an issue to track that this is something that needs to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants