Update Profiler UI for Symfony 6.2+. #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the test fails btw. If I add |
ostrolucky
reviewed
Jan 5, 2023
nickygerritsen
force-pushed
the
profiler-new-ui
branch
from
7bda184 to
dfb9891
Compare
|
I changed the PR quite a bit and only updated the icon and added the metric groups. Once this is merged we can work from there to add the tabs for the different things. I also didn't drop any metrics or changed any order anymore. |
ostrolucky
reviewed
Jan 5, 2023
| <span class="value">{{ collector.invalidEntityCount }}</span> | ||
| <span class="label">Invalid entities</span> | ||
| </div> | ||
| <div class="metric-group"> |
There was a problem hiding this comment.
What are these for? Is it so that it stretches to full width?
There was a problem hiding this comment.
It “groups” the metrics. Look at the screenshots: in 6.1 it is 4 blocks, in 6.2 it is 4 parts of a bigger block. Without it, there would be whitespace between the blocks
ostrolucky
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the closed PR #1558, but only does two changes:
I will do a separate PR to add the tabs.
Screenshot on 6.1:
And on 6.2:
