Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phpunit version and remove minimum-stability flag #512

Merged
merged 3 commits into from
Jun 5, 2015

Conversation

mpalourdio
Copy link
Contributor

The minimum-stability flag seems useless now, please correct me if it's not the case.
phpunit has been bumped to allow ZF 2.5 compliance.

@mpalourdio
Copy link
Contributor Author

Was minimum-stability set to allow "doctrine/common": ">=2.4,<2.6-dev" ?
If so, I can cancel the last commit or set the version to ~2.4, let me know

@gianarb
Copy link
Contributor

gianarb commented Jun 4, 2015

@Ocramius have you feedback about this change?
We are working into the master branch for 1.0.0 stable release and this is a good change.. 👍 ~2.4 :)

@mpalourdio
Copy link
Contributor Author

I was wondering why travis could only get zf 2.4.2 (except on hhvm, see travis logs). I just remembered a problem I had yesterday.

Now that the main repository has been splitted, Zend\Ldap requires ext/ldap. As the extension in not avalaible on travis, composer fallbacks to 2.4.2.

Any workaround regarding php extension and travis you are aware of ? We have the same problem with the PR I submitted to DoctrineORMModule unfortunately.

I watched Zend\Ldap travis config, but they didn't have the problem because they get dependencies via composer require --dev --no-update

@mpalourdio
Copy link
Contributor Author

Ok, so I could add a .travis.ini to load ldap.so, seems to work fine, except for php 5.4 that still download ZF 2.4.2, which is ok as ZF 2.5 requires php 5.5+

Also, php7 builds fail on the bash check, I suspect the missing quotes around hhvm. Isn't weird that the coverage is only on for hhvm ? It doesn't look very judicious to me regarding the build matrix.

I think we should allow coverage for all php versions, excepted for hhvm and php7. What do you think ?

@mpalourdio mpalourdio force-pushed the bump branch 4 times, most recently from cd71fc7 to fceedc5 Compare June 4, 2015 12:17
@mpalourdio
Copy link
Contributor Author

There it is. I have had a rough time with travis to have all the builds back to green !

@mpalourdio
Copy link
Contributor Author

See here for eventually a workaround before considering a merge zendframework/zendframework#7569

@mpalourdio
Copy link
Contributor Author

\o/, this is fixed in zendframework/zendframework#7571. Some commits are still relevant anyway. I can reset and/or squash what is worth.

@mpalourdio
Copy link
Contributor Author

I've added a commit that fixes the builds. It is relevant as with phpunit 4.*, hhvm reports a wrong covering percentage, and with php7, xdebug is not loaded, so no coverage at all.

gianarb pushed a commit that referenced this pull request Jun 5, 2015
Bump phpunit version and remove minimum-stability flag
@gianarb gianarb merged commit 48a1a1b into doctrine:master Jun 5, 2015
@gianarb
Copy link
Contributor

gianarb commented Jun 5, 2015

Thanks!

@mpalourdio mpalourdio deleted the bump branch June 5, 2015 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants