-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump phpunit version and remove minimum-stability flag #512
Conversation
Was minimum-stability set to allow "doctrine/common": ">=2.4,<2.6-dev" ? |
@Ocramius have you feedback about this change? |
I was wondering why travis could only get zf 2.4.2 (except on hhvm, see travis logs). I just remembered a problem I had yesterday. Now that the main repository has been splitted, Zend\Ldap requires ext/ldap. As the extension in not avalaible on travis, composer fallbacks to 2.4.2. Any workaround regarding php extension and travis you are aware of ? We have the same problem with the PR I submitted to DoctrineORMModule unfortunately. I watched Zend\Ldap travis config, but they didn't have the problem because they get dependencies via |
Ok, so I could add a .travis.ini to load ldap.so, seems to work fine, except for php 5.4 that still download ZF 2.4.2, which is ok as ZF 2.5 requires php 5.5+ Also, php7 builds fail on the bash check, I suspect the missing quotes around I think we should allow coverage for all php versions, excepted for hhvm and php7. What do you think ? |
cd71fc7
to
fceedc5
Compare
There it is. I have had a rough time with travis to have all the builds back to green ! |
See here for eventually a workaround before considering a merge zendframework/zendframework#7569 |
\o/, this is fixed in zendframework/zendframework#7571. Some commits are still relevant anyway. I can reset and/or squash what is worth. |
…l php versions except hhvm and php7
I've added a commit that fixes the builds. It is relevant as with phpunit 4.*, hhvm reports a wrong covering percentage, and with php7, xdebug is not loaded, so no coverage at all. |
Bump phpunit version and remove minimum-stability flag
Thanks! |
The minimum-stability flag seems useless now, please correct me if it's not the case.
phpunit has been bumped to allow ZF 2.5 compliance.