Change build paremeters to prevent errors with hhvm and php7 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR could be useless if a workaround is found for ZF2. I've opened an issue here |
|
Fixed in zendframework/zendframework#7571. The commit that fixes the builds is still relevant IMO. Will rework this tonight. |
…ll php versions except hhvm and php7
mpalourdio
changed the title
|
I ended up with just leaving the commit that fixes the builds. It is still relevant as with phpunit 4.*, hhvm reports a wrong covering percentage, and with php7, xdebug is not loaded, so no coverage at all. |
|
Thanks |
gianarb
pushed a commit
that referenced
this pull request
Jun 5, 2015
Change build paremeters to prevent errors with hhvm and php7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See doctrine/DoctrineModule#512 for reference.