Add more new sniffs #11
Conversation
| <!-- Require EOL at EOF --> | ||
| <rule ref="Generic.Files.EndFileNewline"/> | ||
| <!-- Forbid multiple classes per file --> | ||
| <rule ref="Generic.Files.OneClassPerFile"/> |
There was a problem hiding this comment.
This one will be problematic for ORM where tests have their entities defined in the same file. Could be excluded on project level though.
There was a problem hiding this comment.
Should be excluded per-directory IMO
There was a problem hiding this comment.
If that is possible to configure, even better. 👍
There was a problem hiding this comment.
It would simply require a custom local phpcs.xml file per directory to be inspected, with overrides for disabled rules
There was a problem hiding this comment.
Isn't this covered by PSR1.Classes.ClassDeclaration.MultipleClasses (which is part of PSR-2)? If so, we already exclude things in the ORM
There was a problem hiding this comment.
Didn't realize it's already included 👍, we can remove these checks then, PSR-1 sniff provides check for classes/interfaces/traits at once.
There was a problem hiding this comment.
Removed in 2ac121d.
Majkl578
force-pushed
the
more-sniffs
branch
from
3a5a3d8 to
4d1f300
Compare
Majkl578
force-pushed
the
more-sniffs
branch
from
4d1f300 to
c8f1e66
Compare
Second part of new sniffs, this time not 7.1-related, but more generic instead. Comments for each sniff are in the ruleset.
Most of these should already be ok on 99% of code base and are mostly to maintain consistence.
Also removed sniffs for spaces around
!, replaced by generic sniff for spaces after!(as agreed in past and suggested in #9).cc @alcaeus @lcobucci