Import advanced PHP 7.1 sniffs #9

Majkl578 · 2017-09-05T21:44:43Z

Hi,
here's a bunch of great sniffs, most of them requiring PHP 7.1+.

These awesome sniffs are provided under MIT license by Slevomat guys (czech company) at slevomat/coding-standard. Note that I have no affiliation to them, besides some pull requests.
Full list of all available sniffs, their descriptions and options is available in README of the abovementioned repository.

All referenced sniffs are imported explicitly instead of importing whole standard, to avoid unwanted sniffs to appear in newer versions.
Every sniff is accompanied with a comment of its intention.
Note that these sniffs are pretty damn strict. :)

Initial version is mostly based what we're using as internal CS in our company, slightly adjusted for Doctrine.
Some of them may be pretty harsh initially so please let's discuss here what would be applicable and what not.

This will break a lot of things currently since most of the code is still 5.6-like, thus is not applicable to stable branches as is due to BC (some sniffs may be eligible to be backported though). Thus this would target 2.0 milestone here and only be used and applied to develop branches targetting next major (i.e. ORM 3.0).

Follow-up of discussion with @lcobucci in doctrine/common#817.

Majkl578 · 2017-09-05T21:47:03Z

lib/Doctrine/ruleset.xml

+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Namespaces/UseDoesNotStartWithBackslashSniff.php"/>
+
+    <!-- Forbid useless annotations -->
+    <!--<rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Commenting/ForbiddenAnnotationsSniff.php">-->


I've explicitly disabled this sniff, but I think it should eventually be enabled and useless annotations be removed. This includes i.e.:

@author: Git provides more accurate information.

@package: Redundant to namespaces.

I think we can enable it

And it should be SlevomatCodingStandard.Commenting.ForbiddenAnnotations

Enabled for @author, @created, @copyright, @license, @package, @since, @version. All these are provided by Git or LICENCE file.

Majkl578 · 2017-09-05T21:48:08Z

lib/Doctrine/ruleset.xml

+    <!-- Require ? when default value is null -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/NullableTypeForNullDefaultValueSniff.php"/>
+
+    <!-- Require one space between typehint and variable, require no space between nullability sign and typehint -->


Requires function foo(?Bar $bar) format.

Majkl578 · 2017-09-05T21:48:41Z

lib/Doctrine/ruleset.xml

+    <!-- Require presence of constant visibility -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Classes/ClassConstantVisibilitySniff.php"/>
+
+    <!-- Require ? when default value is null -->


Requires function foo(?Bar $bar = null) format instead of function foo(Bar $bar = null).

Not sure what is the point of this one...

To force presence of ? when parameter is supposed to be nullable.

That I understood, but what's the benefit?

Please read the discussion here: doctrine/common#805 (comment), I explained the reasons there. 😊

The LSP argument is very convincing!

Majkl578 · 2017-09-05T21:49:38Z

lib/Doctrine/ruleset.xml

+    <!-- Require using Throwable instead of Exception -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Exceptions/ReferenceThrowableOnlySniff.php"/>
+
+    <!-- Require presence of declare(strict_types=1) -->


Requires file to begin with:

<?php declare(strict_types=1) <anything else>

Majkl578 · 2017-09-05T21:53:04Z

lib/Doctrine/ruleset.xml

+    <!-- Require types to be written as natively if possible;
+         require iterable types to specify phpDoc with their contnet;
+         forbid useless/duplicated information in php doc -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/TypeHintDeclarationSniff.php">


This sniff is pretty advanced:

Requires native types be expressed natively (i.e. scalar types).

Requires iterable types (array/iterable/custom) have specified what they contain, i.e. @return Foo[].

Forbids duplication of type information - all @param and @return are forbidden unless they're mixed, traversable or explicit description is given.

That last one looks awesome

greg0ire · 2017-09-05T22:27:47Z

lib/Doctrine/ruleset.xml

+    </rule>
+
+    <!-- Require types to be written as natively if possible;
+         require iterable types to specify phpDoc with their contnet;


greg0ire · 2017-09-05T22:30:40Z

lib/Doctrine/ruleset.xml

+    </rule>
+
+    <!-- Forbid assignments in conditions -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/ControlStructures/AssignmentInConditionSniff.php"/>


If that's the price to pay to avoid Yoda, 👍
I wrote about this lately, BTW

greg0ire · 2017-09-05T22:31:33Z

lib/Doctrine/ruleset.xml

+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Arrays/TrailingArrayCommaSniff.php"/>
+
+    <!-- Forbid fancy yoda conditions -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/ControlStructures/YodaComparisonSniff.php"/>


Damn right!

This should be SlevomatCodingStandard.ControlStructures.YodaComparison

mhujer · 2017-09-06T09:29:14Z

lib/Doctrine/Sniffs/Spacing/ControlStructureSniff.php

@@ -57,7 +40,11 @@ public function register()
        ];
    }

-    public function process(File $phpcsFile, $stackPtr)
+    /**
+     * @phpcsSuppress SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint


@Majkl578 I usually add a comment explaining, why the sniff is suppressed

True, but I think the name is pretty self-explaining in this case: Type Hint Declaration - Missing Parameter Type Hint

Majkl578 · 2017-12-08T23:08:22Z

ping @lcobucci

alcaeus · 2017-12-09T20:02:40Z

Ping @Ocramius @malarzm

lcobucci

I really like this idea and I didn't know of slevomat/coding-standard, quite cool!

I wonder if would be nice to add FullyQualifiedGlobalConstantsSniff and FullyQualifiedGlobalFunctionsSniff to the list.

lcobucci · 2017-12-16T21:24:46Z

composer.json

@@ -17,7 +17,8 @@
    "require": {
        "php": "^7.1",
        "squizlabs/php_codesniffer": "~3.0",
-        "dealerdirect/phpcodesniffer-composer-installer": "^0.4.2"
+        "dealerdirect/phpcodesniffer-composer-installer": "^0.4.2",
+        "slevomat/coding-standard": "3.3.*"


Can we require ^4.0 instead? They have changed the composer project type, then dealerdirect/phpcodesniffer-composer-installer will be able to install it automatically for us (and we don't need to use file paths)

Yep, I'll update it and the way how we reference sniff. There was no 4.0 release back when I created this PR. 👍

lcobucci · 2017-12-16T21:28:03Z

lib/Doctrine/ruleset.xml

@@ -30,4 +30,149 @@
            <property name="ignoreNewlines" value="true"/>
        </properties>
    </rule>
+
+    <!-- Forbid using absolute class name references (except global ones) -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Namespaces/ReferenceUsedNamesOnlySniff.php">


This should be SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly

lcobucci · 2017-12-16T21:28:46Z

lib/Doctrine/ruleset.xml

+    </rule>
+
+    <!-- Forbid empty lines around type declarations -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Types/EmptyLinesAroundTypeBracesSniff.php">


This should be SlevomatCodingStandard.Types.EmptyLinesAroundTypeBraces

lcobucci · 2017-12-16T21:29:45Z

lib/Doctrine/ruleset.xml

+    </rule>
+
+    <!-- Require space around colon in return types -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/ReturnTypeHintSpacingSniff.php">


This should be SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing

lcobucci · 2017-12-16T21:31:03Z

lib/Doctrine/ruleset.xml

+    <!-- Require types to be written as natively if possible;
+         require iterable types to specify phpDoc with their content;
+         forbid useless/duplicated information in phpDoc -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/TypeHintDeclarationSniff.php">


This should be SlevomatCodingStandard.TypeHints.TypeHintDeclaration

lcobucci · 2017-12-16T21:39:36Z

lib/Doctrine/ruleset.xml

+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Namespaces/UseDoesNotStartWithBackslashSniff.php"/>
+
+    <!-- Forbid useless annotations -->
+    <!--<rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Commenting/ForbiddenAnnotationsSniff.php">-->


I think we can enable it

lcobucci · 2017-12-16T21:39:58Z

lib/Doctrine/ruleset.xml

+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Namespaces/UseDoesNotStartWithBackslashSniff.php"/>
+
+    <!-- Forbid useless annotations -->
+    <!--<rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Commenting/ForbiddenAnnotationsSniff.php">-->


And it should be SlevomatCodingStandard.Commenting.ForbiddenAnnotations

lcobucci · 2017-12-16T21:40:12Z

lib/Doctrine/ruleset.xml

+    <!--</rule>-->
+
+    <!-- report invalid format of inline phpDocs with @var -->
+    <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Commenting/InlineDocCommentDeclarationSniff.php"/>


This should be SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration

lcobucci · 2017-12-16T21:40:54Z

tests/fixed/return_type_on_closures.php

@@ -1,61 +0,0 @@
-<?php
-
-function () : void {


Why are we removing this? The idea of these tests was to provide examples and ensure that, regardless if we're providing the sniffs or using sniffs from a package, things are working properly (in Travis)

Afaik these are already provided via rules from Slevomat CS (SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing) and seemed redundant to their tests, but can check again. The tests otherwise don't look like a full representation of this PR so it didn't make much sense to me to keep it.
If we want to test full CS, we can add more specific tests.

These tests were added in cdce50d to cover SpaceOnReturnTypeSniff defined by this CS. It's now replaced by external sniff.

Actually I added the tests to validate the configuration of the ruleset and not individual sniffs (regardless of what package provides the sniffs). But sure this is up for discussion 😄

My concern was to ensure that we're setting everything the way we want and we don't have any side effect.

Ok, I've reverted the removal, updated it and added extra example class. 😎

lcobucci · 2017-12-16T21:48:44Z

lib/Doctrine/Sniffs/Spacing/EnsureSpaces.php

@@ -25,6 +8,9 @@

 trait EnsureSpaces


We can move these methods to Doctrine\Sniffs\Spacing\SpaceOnNotSniff, which is the only class that uses it

Majkl578 · 2017-12-17T17:07:01Z

lib/Doctrine/ruleset.xml

+    <rule ref="SlevomatCodingStandard.Arrays.TrailingArrayComma"/>
+
+    <!-- Forbid fancy yoda conditions -->
+    <rule ref="SlevomatCodingStandard.ControlStructures.DisallowYodaComparison"/>


Based on doctrine/orm#6888, disallowing Yoda conditions should be discussed. I've already expressed my negative feelings in the PR, what do others think?

I'm all for not using Yoda conditions. The last time I made a typo like if ($foo = 'bar') was longer than 10 years ago. Mutation testing is much better in finding untested conditions.

Majkl578 · 2017-12-17T17:10:48Z

Upgraded to version 4.0, changed the way we reference external sniffs.

I wonder if would be nice to add FullyQualifiedGlobalConstantsSniff and FullyQualifiedGlobalFunctionsSniff to the list.

See doctrine/orm#6807, @Ocramius suggested using use function foo; to import them, that idea seems neat and doesn't pollute code with \.

morozov · 2017-12-18T00:18:06Z

lib/Doctrine/Sniffs/Spacing/SpaceOnNotSniff.php

    {
        return [\T_BOOLEAN_NOT];
    }

-    public function process(File $phpcsFile, $stackPtr)
+    /**
+     * @phpcsSuppress SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint


I wish there was a way to not pollute code with standard-specific annotations and have exceptions described in an external file (like PHPStan does).

I think this exact one (with no typehint) should be also suppressable by adding @param annotation.

phpcsSuppress should be the exception - especially for this one. MissingParameterTypeHint requires either a type declaration on the parameter or a @param docblock, so there should be @param, not @phpcsSuppress.

There isn't actually much cases where you would need that annotation, its use is mostly exceptional (like design errors i.e. write-only property).
Otherwise in this case @param is provided by parent declaration.

Tried removing it, but realized it must be kept, because otherwise CS will report int not being used natively - but it can't be, parent forces mixed. Unfortunately CS has no way to know, it only has single file scope. :(

morozov · 2017-12-18T00:22:05Z

lib/Doctrine/ruleset.xml

+        <properties>
+            <property
+                name="newlinesCountBetweenOpenTagAndDeclare"
+                value="2"


Personally, I find this formatting better:

<?php declare(strict_types=1);

It kind of makes the declare part of the file header.

Let's stick to the (upcoming) PSR-12 as much as possible please. See https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md#3-declare-statements-namespace-and-import-statements

It kind of makes the declare part of the file header.

Which is exactly the problem. declare is a statement like many others and strict_types may not be the only statement:

<?php declare(strict_types=1); declare(ticks = 1);

Agreed with @alcaeus, declare could be anywhere in the file, it's only strict_types that must be first statement. Also in future it's possible there will be more similar declare statements.
Personally I don't see a reason to follow PSR-12, it's not a standard, is unfinished and Doctrine is not part of FIG group.
Btw we already use strict types in ORM (doctrine/orm#6524) and format was discussed by @Ocramius.

Personally I don't see a reason to follow PSR-12, it's not a standard, is unfinished

Correct - it's currently still in a draft phase.

and Doctrine is not part of FIG group.

Which means we are not involved in the creation and adoption of new PSRs. By the same logic, we might as well drop PSR-2, start using tabs and roll our own autoloading standard because we dislike PSR-0 and PSR-4 and we're not part of PHP-FIG.

What I meant is that Doctrine is not part of FIG and is then not obliged to follow PSR. On the other hand, it's not reason to not follow PSRs that are compatible with Doctrine's vision, like currently PSR-2.

Let's stick to the (upcoming) PSR-12 as much as possible please.

Didn't know it's a thing. Let's stick to the standard.

morozov · 2017-12-18T00:26:59Z

lib/Doctrine/ruleset.xml

+    <rule ref="SlevomatCodingStandard.Namespaces.UseDoesNotStartWithBackslash"/>
+
+    <!-- Forbid useless annotations -->
+    <!--<rule ref="SlevomatCodingStandard.Commenting.ForbiddenAnnotations">-->


Is there a sniff which forbids committing commented out code? :-)

This one makes sense to me.

Of course: Squiz.PHP.CommentedOutCode

Yeah, but why is this block commented out?

I originally copied out this part from our company's coding standard, probably commented it out because ORM still uses @author, @since etc. I'm all for enabing it and removing redundant annotations, Git's history/blame provide more accurate information.

Same here. Let's get this rule enabled.

alcaeus

FWIW, I'm still not happy with the return type declaration. PSR-12 specifies (in https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md#45-method-and-function-arguments):

When you have a return type declaration present there MUST be one space after the colon followed by the type declaration. The colon and declaration MUST be on the same line as the argument list closing parentheses with no spaces between the two characters. The declaration keyword (e.g. string) MUST be lowercase.

Most code I've seen so far (with the notable exception of anything written by @Ocramius) also follows that notation, so it would make sense for us to not do it differently: there's no advantage to the space before the colon and we don't use it in other places either (e.g. switch):

switch ($foo) {
    case 'something' :
        break;
    // ...
}

Ocramius

@Majkl578 due to #11, this patch needs another rebase

Majkl578 · 2017-12-26T21:23:59Z

Rebased. And sniffs reordered alphabetically.

Ocramius

LGTM 🚢

alcaeus · 2017-12-29T11:04:20Z

@Majkl578 not sure if the result of the votes is already factored in. Except for the "spaces around colon" vote they are pretty one-sides. As for that one that isn't, counting doctrine team members results in favor of "spaces around colon", so I suggest we use that for now and possibly revisit this if PSR-12 ever becomes a thing (and makes sense; see spaces around equal sign within declare).

Majkl578 · 2017-12-29T14:30:11Z

@alcaeus As far as I checked the proposed ruleset matches the results so no change was needed. As for the rules proposed by @carusogabriel - we currently have no sniff implementing them. ! spacing was handled in #11. Did I miss something?
For the return spacing, feel free to override the rule on project-level.

carusogabriel · 2017-12-29T22:36:36Z

@Majkl578 Should I PR my proposed rules? 😄

[PSR-12](https://www.php-fig.org/psr/psr-12) is an extension of the PSR-2 set of rules that aims to standardize the code style. Doctrine, so far, hasn't adopted 100% off it, and this PR proposes to start to migrate our rules to PSR-12. The first one is the return types. As described under the section [4.5](https://www.php-fig.org/psr/psr-12/#45-method-and-function-arguments), they SHOULD NOT be a blank space between the return type and colon (`:`). For context on why this was voted in the past, see #9.# Please enter the commit message for your changes. Lines starting

[PSR-12](https://www.php-fig.org/psr/psr-12) is an extension of the PSR-2 set of rules that aims to standardize the code style. As per PSR-12, under the [item 3](https://www.php-fig.org/psr/psr-12/#3-declare-statements-namespace-and-import-statements): The header of a PHP file may consist of a number of different blocks. If present, each of the blocks below MUST be separated by a single blank line, and MUST NOT contain a blank line. Each block MUST be in the order listed below, although blocks that are not relevant may be omitted. For context on why this was voted in the past, see #9.

Majkl578 added Improvement WIP labels Sep 5, 2017

Majkl578 requested a review from lcobucci September 5, 2017 21:44

Majkl578 commented Sep 5, 2017

View reviewed changes

Majkl578 force-pushed the advanced-sniffs branch from f59c7bd to f03e13b Compare September 5, 2017 22:26

greg0ire reviewed Sep 5, 2017

View reviewed changes

Majkl578 force-pushed the advanced-sniffs branch 3 times, most recently from 7fff2c1 to 72dfd0f Compare September 5, 2017 22:49

mhujer reviewed Sep 6, 2017

View reviewed changes

Majkl578 mentioned this pull request Sep 16, 2017

use yoda comparison doctrine/migrations#549

Closed

alcaeus approved these changes Dec 9, 2017

View reviewed changes

Majkl578 mentioned this pull request Dec 14, 2017

Yoda conditions abolished should be doctrine/orm#6888

Closed

lcobucci suggested changes Dec 16, 2017

View reviewed changes

Majkl578 force-pushed the advanced-sniffs branch 3 times, most recently from c434d3e to 3e7e982 Compare December 17, 2017 16:54

Majkl578 commented Dec 17, 2017

View reviewed changes

This was referenced Dec 17, 2017

Removing license header #10

Merged

Incremental check for coding standards in pull requests doctrine/dbal#2936

Merged

Majkl578 removed the WIP label Dec 18, 2017

morozov reviewed Dec 18, 2017

View reviewed changes

alcaeus requested changes Dec 18, 2017

View reviewed changes

Majkl578 mentioned this pull request Dec 26, 2017

Add more new sniffs #11

Merged

Ocramius suggested changes Dec 26, 2017

View reviewed changes

Import advanced PHP 7.1 sniffs

69af948

Majkl578 force-pushed the advanced-sniffs branch from 23404e5 to 69af948 Compare December 26, 2017 21:20

Ocramius approved these changes Dec 26, 2017

View reviewed changes

Ocramius self-assigned this Dec 26, 2017

Ocramius added this to the 1.0.0 milestone Dec 26, 2017

Ocramius merged commit 5b65b75 into doctrine:master Dec 26, 2017

Majkl578 mentioned this pull request Dec 27, 2017

Update README with newer rules #12

Merged

Majkl578 deleted the advanced-sniffs branch December 27, 2017 01:08

Slamdunk mentioned this pull request Dec 29, 2017

Move to PHP-CS-Fixer #13

Closed

2 tasks

Majkl578 modified the milestones: 1.0.0, 1.1.0 Dec 29, 2017

Majkl578 mentioned this pull request Jan 2, 2018

[CS] is_null($var) -> null === $var doctrine/orm#6948

Merged

This was referenced Jan 29, 2018

Propose semantic versioning of the library #18

Merged

Add Null Coalesce Operator #19

Closed

New with parentheses #20

Merged

Majkl578 mentioned this pull request Jun 19, 2018

[WIP] Apply Doctrine CS schmittjoh/serializer#968

Closed

carusogabriel mentioned this pull request Dec 27, 2019

Adopt PSR-12 as base coding standard #148

Merged

carusogabriel mentioned this pull request Mar 19, 2020

Adopt PSR-12 for return types #163

Merged

carusogabriel mentioned this pull request Mar 20, 2020

Adopt PSR-12 for imports statements separation #164

Merged

greg0ire mentioned this pull request Apr 19, 2020

Remove dead sniffs autoload #176

Merged

Import advanced PHP 7.1 sniffs #9

Import advanced PHP 7.1 sniffs #9

Conversation

Majkl578 commented Sep 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majkl578 Sep 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majkl578 Sep 6, 2017 • edited Loading

Choose a reason for hiding this comment

Majkl578 commented Dec 8, 2017

alcaeus commented Dec 9, 2017

lcobucci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majkl578 commented Dec 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

morozov Dec 18, 2017 • edited Loading

Choose a reason for hiding this comment

morozov Dec 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majkl578 Dec 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alcaeus left a comment

Choose a reason for hiding this comment

Ocramius left a comment

Choose a reason for hiding this comment

Majkl578 commented Dec 26, 2017

Ocramius left a comment

Choose a reason for hiding this comment

alcaeus commented Dec 29, 2017

Majkl578 commented Dec 29, 2017 • edited Loading

carusogabriel commented Dec 29, 2017

Majkl578 Sep 5, 2017 •

edited

Loading

Majkl578 Sep 6, 2017 •

edited

Loading

morozov Dec 18, 2017 •

edited

Loading

morozov Dec 18, 2017 •

edited

Loading

Majkl578 Dec 18, 2017 •

edited

Loading

Majkl578 commented Dec 29, 2017 •

edited

Loading