[CS] is_null($var) -> null === $var #6948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚢 thanks @Slamdunk! |
|
FYI: This shouldn't be using Yoda as per vote in doctrine/coding-standard#9. |
|
If I got it right, when you'll finish the work on https://github.com/doctrine/coding-standard/ you'll apply it to all the doctrine codebase, and so the code will be fixed, right? |
|
Yes, just better to not introduce code that needs modifications a week later. :) Doesn't matter now when merged. |
I agree, I asked because in opposite case I would have opened another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was applied with PHP-CS-Fixer rule
is_null.