chore(NA): assure puppeteer_skip_chromium_download is applied across …

…every yarn install situation (elastic#88346)
dominiqueclarke · Jan 14, 2021 · be1eb4c · be1eb4c
1 parent f33225d
commit be1eb4c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/.npmrc b/.npmrc
@@ -0,0 +1 @@
+puppeteer_skip_chromium_download=true
diff --git a/package.json b/package.json
@@ -19,9 +19,6 @@
     "number": 8467,
     "sha": "6cb7fec4e154faa0a4a3fee4b33dfef91b9870d9"
   },
-  "config": {
-    "puppeteer_skip_chromium_download": true
-  },
   "homepage": "https://www.elastic.co/products/kibana",
   "bugs": {
     "url": "http://github.com/elastic/kibana/issues"

diff --git a/src/dev/build/tasks/clean_tasks.ts b/src/dev/build/tasks/clean_tasks.ts
@@ -41,7 +41,10 @@ export const CleanPackages: Task = {
   description: 'Cleaning source for packages that are now installed in node_modules',
 
   async run(config, log, build) {
-    await deleteAll([build.resolvePath('packages'), build.resolvePath('yarn.lock')], log);
+    await deleteAll(
+      [build.resolvePath('packages'), build.resolvePath('yarn.lock'), build.resolvePath('.npmrc')],
+      log
+    );
   },
 };
 

diff --git a/src/dev/build/tasks/copy_source_task.ts b/src/dev/build/tasks/copy_source_task.ts
@@ -27,6 +27,7 @@ export const CopySource: Task = {
       dot: false,
       select: [
         'yarn.lock',
+        '.npmrc',
         'src/**',
         '!src/**/*.{test,test.mocks,mock}.{js,ts,tsx}',
         '!src/**/mocks.ts', // special file who imports .mock files