Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum_frame_interval not working as expected #34

Closed
tarushnagpal opened this issue Jan 22, 2024 · 3 comments
Closed

minimum_frame_interval not working as expected #34

tarushnagpal opened this issue Jan 22, 2024 · 3 comments

Comments

@tarushnagpal
Copy link

Hey! Great work on the project it's great to use.

I am facing an issue with this stream configuration,
SCStreamConfiguration { shows_cursor: true, width: 100, height: 100, scales_to_fit: true, pixel_format: PixelFormat::ARGB8888, minimum_frame_interval: CMTime { value: 3, timescale: 1, flags: 1, epoch: 0, }, ..Default::default() };

According to this CMTime, I should be getting 1 frame every 3 seconds, but it doesn't seem to be respected as I am still getting 60fps.

@tarushnagpal
Copy link
Author

@1313
Copy link
Collaborator

1313 commented Jan 22, 2024

I will fix together with the other issue you mention. Thx for reporting!

@tarushnagpal
Copy link
Author

Thank you, btw scales_to_fit also doesn't seem to be working

@1313 1313 closed this as completed in b327a66 Jan 23, 2024
1313 added a commit that referenced this issue Jan 29, 2024
* main: (21 commits)
  Update CHANGELOG.md
  v0.2.5
  fix: Fix wrong config setting PreservesAspectRatio
  v0.2.4
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  fix: #34 Add additional configuration settings, Awaiting #27 for the rest
  fix: #33 Reexport SCFrameStatus SYS-type
  Update rust.yml
  CI
  Update rust.yml
  Update rust.yml
  Update rust.yml
  v0.2.3
  Update README.md
  Update .all-contributorsrc
  docs: add Pranav2612000 as a contributor for code (#32)
  feat: add support for pixel_format and source_rect (#30)
  v0.2.2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants