Use Core Foundation crate for CF types instead of using Id<_>
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1313
force-pushed
the
main
branch
4 times, most recently
from
e2668bf to
86bc2e8
Compare
1313
added a commit
that referenced
this pull request
Jan 23, 2024
* main: (21 commits) Update CHANGELOG.md v0.2.5 fix: Fix wrong config setting PreservesAspectRatio v0.2.4 Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md fix: #34 Add additional configuration settings, Awaiting #27 for the rest fix: #33 Reexport SCFrameStatus SYS-type Update rust.yml CI Update rust.yml Update rust.yml Update rust.yml v0.2.3 Update README.md Update .all-contributorsrc docs: add Pranav2612000 as a contributor for code (#32) feat: add support for pixel_format and source_rect (#30) v0.2.2 ...
Merged
Signed-off-by: Per Johansson <[email protected]>
Signed-off-by: Per Johansson <[email protected]>
Signed-off-by: Per Johansson <[email protected]>
Signed-off-by: Per Johansson <[email protected]>
|
If I want to start using this crate, should I be using this PR? |
Closed
|
Most of the core is done. I'm adding audio capture at the moment. But have not tested it a lot so it could come with initial bugs. Also need to scan it for memory leaks. But using core-foundation as a base it should be a lot easier. So soon. I could push out an alpha for version 0.3 if you want to start testing it. Cheers |
|
Thanks @1313 definitely would like to test it out anytime its ready |
* main: Update README.md Update README.md feat: Set sample_rate and channel_count via objc interface (#48) fix: pass correct args to content filter init methods (#47) update changelog feat: add support for shows_cursor (#45) fix changelog v0.2.7 v0.2.7 Fix ShareableContent when permissions are missing (#42) remove bad code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CF provides a better way to interopt and better manage memory with ref counts using the correct retain/release lifecycles.
See: https://github.com/servo/core-foundation-rs
And: https://docs.rs/core-foundation/0.9.4/core_foundation/macro.declare_TCFType.html