Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for shows_cursor #45

Merged

Conversation

Pranav2612000
Copy link
Contributor

@Pranav2612000 Pranav2612000 commented Apr 27, 2024

Screen capture kit has a showsCursor setting configuration which allows the user to decide whether to show the cursor or not in the frames capture. ( https://developer.apple.com/documentation/screencapturekit/scstreamconfiguration/3919828-showscursor )

This PR adds support for this option.

@1313 1313 merged commit 4b90e58 into doom-fish:main Apr 27, 2024
1 check passed
@Pranav2612000
Copy link
Contributor Author

Thank you for merging this @1313 . Do you have any plans on when you'll be making a release?

@1313
Copy link
Collaborator

1313 commented Apr 27, 2024

Np.
I can do it later today

@1313
Copy link
Collaborator

1313 commented Apr 29, 2024

A bit late but pushed

@Pranav2612000
Copy link
Contributor Author

A bit late but pushed

No problem. Thank you 🙇🏾

1313 added a commit that referenced this pull request Oct 22, 2024
* main:
  Update README.md
  Update README.md
  feat: Set sample_rate and channel_count via objc interface (#48)
  fix: pass correct args to content filter init methods (#47)
  update changelog
  feat: add support for shows_cursor (#45)
  fix changelog
  v0.2.7
  v0.2.7
  Fix ShareableContent when permissions are missing (#42)
  remove bad code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants