feat: Set sample_rate and channel_count via objc interface #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: I'm not able to set `channel_count` and `sample_rate` in StreamConfiguration as a consumer of this library. Solution: Wire up the setter calls to the actual operations to set the aforementioned attributes via objc interface. Testing: Tested on my Macbook. I'm able to update the aforementioned attributes and see the changes reflected in the channel count and sample rate of the audio samples that I'm receiving in `did_output_sample_buffer` callback. Reviewer guidance: I am only adding the missing attributes that I need. I'm aware that there are still remaining attributes that are not set via objc interface but decided to only focus on `sample_rate` and `channel_count` attributes in this PR since I have high confidence that they would work from my local testing. Signed-off-by: Alex Jiao <[email protected]>
|
Cool 😎 |
1313
added a commit
that referenced
this pull request
Oct 22, 2024
* main: Update README.md Update README.md feat: Set sample_rate and channel_count via objc interface (#48) fix: pass correct args to content filter init methods (#47) update changelog feat: add support for shows_cursor (#45) fix changelog v0.2.7 v0.2.7 Fix ShareableContent when permissions are missing (#42) remove bad code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: I'm not able to set
channel_countandsample_ratein StreamConfiguration as a consumer of this library.Solution: Wire up the setter calls to the actual operations to set the aforementioned attributes via objc interface.
Testing: Tested on my Macbook. I'm able to update the aforementioned attributes and see the changes reflected in the channel count and sample rate of the audio samples that I'm receiving in
did_output_sample_buffercallback.Reviewer guidance: I am only adding the missing attributes that I need. I'm aware that there are still remaining attributes that are not set via objc interface but decided to only focus on
sample_rateandchannel_countattributes in this PR since I have high confidence that they would work from my local testing.