The push publish button in the expansion menu on the users portlet doesn't just push the selected user, it pushes all users #22149

swicken-dotcms · 2022-05-04T15:59:26Z

Describe the bug
When you utilize the menu in the top right corner of the users portlet to push publish, it pushes every user and not only the selected one.

Reproduced on: 22.03, 21.06
Ticket: https://dotcms.zendesk.com/agent/tickets/107128

To Reproduce
Steps to reproduce the behavior:

Set up a sender/receiver
Go to the users portlet
Select a user
Click the 'Push Publish' button in the top right menu, every user will be included in the bundle

Expected behavior
The button should either only push the selected user, or it should be explicit that it will push every user.

freddyucv · 2022-07-01T17:57:49Z

We are going to change the menu labels by: "Push All Users" and "Add All Users to Bundle" Also but just if No user is selected.

I mean this Menu label

This reverts commit 0251c87.

This reverts commit 6c2f5fb.

freddyucv · 2022-07-05T16:42:32Z

Doc : Needs Doc: We need to update this

https://www.dotcms.com/docs/latest/pushing-users

…22504) * #22149 Adding into the bundle just the selected user when one exists * #22149 Change menu message when no User is Selected * #22149 Add Id to menu Item * Changing message

* #22508 Add User into the Manifest * #22149 Change Menu label wheter user is selected or not * #22149 Change message when any user is selected * Revert "#22149 Change message when any user is selected" This reverts commit 0251c87. * Revert "#22149 Change Menu label wheter user is selected or not" This reverts commit 6c2f5fb. * #22508 Testing and Fixing Manifest bug * Fixing test * Adding javadoc * Removing NotNull

hmoreras · 2022-07-12T21:07:12Z

This change, 6ff401d#diff-13ac5ee29d2bbbc164e8f347146d3f34f73a67e1680a13c4bca15761813c5a62R307

Is breaking the users portlet in master and release-22.07, we need to add extra validation there.

dsilvam · 2022-07-12T21:19:03Z

@hmoreras 's comment was addressed on the last PR #22561

* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 22.07, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-22.07 * Update branch in git submodule to release-22.07 * CI: bumps version to 22.7.0-rc.11 [skip ci] * #22496 fix tail log Whitespaces are printed sometimes at the beginning of the lines (#22538) * #22508 Add User into the Manifest (#22511) * #22508 Add User into the Manifest * #22149 Change Menu label wheter user is selected or not * #22149 Change message when any user is selected * Revert "#22149 Change message when any user is selected" This reverts commit 0251c87. * Revert "#22149 Change Menu label wheter user is selected or not" This reverts commit 6c2f5fb. * #22508 Testing and Fixing Manifest bug * Fixing test * Adding javadoc * Removing NotNull * #22463 Support old scale redirecting to resize (#22515) * #22463 Support old scale redirecting to resize * #22463 update expected content-type * Revert "#22463 update expected content-type" This reverts commit abebd0e. * #22463 debugging filters * More logging * Logging * Testing * Undo logging * #22489 Remove "Beta" from the block editor field name * Fix red * #22552 fix Log Filter: The console gets blank after switching log files (#22557) * Postman tests fixes (#22555) * Adding duration to postman collection run * Fixing and improving postman tests * Directly removing GITHUB context displaying * Enabling workflow steps * #22501 Drag-N-Drop Navigation reorder not affecting changes to nav menu In the previous release, we updated the `Folder` class to stop inheriting from `Inode`. The menu reordering code was relying on that, so it stopped working after the change. We're now passing down the Identifier to make it work as expected. * Renabling chain of jobs-steps at main workflow * Fixing typo * #22554 22149 Handle no-license and no-endpoints scenarios and other fixes (#22561) * #22501 Missing change from previous PR. (#22564) * Postman improvements (#22565) * Tuning tests in general * nop * #22338 Fixed dupe widgets * fix: prevent widgets from being repeated * fix: comment * CI: bumps version to 22.7.0-rc.24 [skip ci] * Fix annotations (#22572) * Fix annotations * Update HostFactoryImpl.java * Exclude HostAPITest from mainsuite Co-authored-by: freddyucv <[email protected]> * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. (#22576) * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Code Review changes. * Update gradle.properties * Update release-process.yml Co-authored-by: victoralfaro-dotcms <[email protected]> Co-authored-by: alfredo-dotcms <[email protected]> Co-authored-by: Freddy Rodriguez <[email protected]> Co-authored-by: Humberto Morera <[email protected]> Co-authored-by: Jose Castro <[email protected]> Co-authored-by: Rafael Velazco <[email protected]>

victoralfaro-dotcms · 2022-07-25T23:02:21Z

Sender users:

Receiver users:

Details at sender's publish queue:

Pushed user at receiver:

Labels when no user is selected:

Labels when user is selected:

No javascript errors when no endpoints nor a license is configured properly.

* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 22.07, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-22.07 * Update branch in git submodule to release-22.07 * CI: bumps version to 22.7.0-rc.11 [skip ci] * #22496 fix tail log Whitespaces are printed sometimes at the beginning of the lines (#22538) * #22508 Add User into the Manifest (#22511) * #22508 Add User into the Manifest * #22149 Change Menu label wheter user is selected or not * #22149 Change message when any user is selected * Revert "#22149 Change message when any user is selected" This reverts commit 0251c87. * Revert "#22149 Change Menu label wheter user is selected or not" This reverts commit 6c2f5fb. * #22508 Testing and Fixing Manifest bug * Fixing test * Adding javadoc * Removing NotNull * #22463 Support old scale redirecting to resize (#22515) * #22463 Support old scale redirecting to resize * #22463 update expected content-type * Revert "#22463 update expected content-type" This reverts commit abebd0e. * #22463 debugging filters * More logging * Logging * Testing * Undo logging * #22489 Remove "Beta" from the block editor field name * Fix red * #22552 fix Log Filter: The console gets blank after switching log files (#22557) * Postman tests fixes (#22555) * Adding duration to postman collection run * Fixing and improving postman tests * Directly removing GITHUB context displaying * Enabling workflow steps * #22501 Drag-N-Drop Navigation reorder not affecting changes to nav menu In the previous release, we updated the `Folder` class to stop inheriting from `Inode`. The menu reordering code was relying on that, so it stopped working after the change. We're now passing down the Identifier to make it work as expected. * Renabling chain of jobs-steps at main workflow * Fixing typo * #22554 22149 Handle no-license and no-endpoints scenarios and other fixes (#22561) * #22501 Missing change from previous PR. (#22564) * Postman improvements (#22565) * Tuning tests in general * nop * #22338 Fixed dupe widgets * fix: prevent widgets from being repeated * fix: comment * CI: bumps version to 22.7.0-rc.24 [skip ci] * Fix annotations (#22572) * Fix annotations * Update HostFactoryImpl.java * Exclude HostAPITest from mainsuite Co-authored-by: freddyucv <[email protected]> * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. (#22576) * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Code Review changes. * New starter generated. Version: 20220713 (#22568) Co-authored-by: nollymar <[email protected]> * new empty starter (#22586) * CI: bumps version to 22.7.0-rc.25 [skip ci] * CI: bumps version to 22.7.0-rc.26 [skip ci] * Trigger dotcms-ui build in 22.07 (#22591) * Revert "Trigger dotcms-ui build in 22.07 (#22591)" This reverts commit 7c7ed00. * CI: bumps version to 22.7.0-rc.27 [skip ci] * Trigger dotcms-ui build in 22.07 with copy prepare to fix (#22592) * Trigger dotcms-ui build * CI: bumps version to 22.7.0-rc.28 [skip ci] * Notify to slack dotcms-ui build (#22595) * Fix the slack notification in dotcms-ui * CI: bumps version to 22.7.0-rc.29 [skip ci] * #20840 System Workflow should be used as default when no license is set * #20840 adding changes when no license shows the system workflow * #20840 refactoring the unit test * Revert changes (#22505) * Update README.md * Update README.md * (#22605): Fix of wrong keyword to replace when running migration task. (#22613) * #22168 Correct the generated REST URLs from Content Search 'Show Query' (#22590) (#22620) * #22615 respect FE roles true (#22616) * #22615 respect FE roles true * #22615 Postman test * #22559 Do respond pages in case of 404. Postman added (#22575) * #22559 Do respond pages in case of 404. Postman added * Update VanityURL.postman_collection.json * Update postman * disable cookies * Update VanityURL.postman_collection.json * #22559 missing asset in bundle * Leave values for master Co-authored-by: victoralfaro-dotcms <[email protected]> Co-authored-by: alfredo-dotcms <[email protected]> Co-authored-by: Freddy Rodriguez <[email protected]> Co-authored-by: Humberto Morera <[email protected]> Co-authored-by: Jose Castro <[email protected]> Co-authored-by: Rafael Velazco <[email protected]> Co-authored-by: Nollymar Longa <[email protected]> Co-authored-by: nollymar <[email protected]> Co-authored-by: Freddy Montes <[email protected]> Co-authored-by: Jonathan <[email protected]>

bryanboza · 2022-07-28T20:18:45Z

Fixed , tested on release-22.07 // Docker // FF. Now I'm able to push a single user using this button without problems

* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 22.07, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-22.07 * Update branch in git submodule to release-22.07 * CI: bumps version to 22.7.0-rc.11 [skip ci] * #22496 fix tail log Whitespaces are printed sometimes at the beginning of the lines (#22538) * #22508 Add User into the Manifest (#22511) * #22508 Add User into the Manifest * #22149 Change Menu label wheter user is selected or not * #22149 Change message when any user is selected * Revert "#22149 Change message when any user is selected" This reverts commit 0251c87. * Revert "#22149 Change Menu label wheter user is selected or not" This reverts commit 6c2f5fb. * #22508 Testing and Fixing Manifest bug * Fixing test * Adding javadoc * Removing NotNull * #22463 Support old scale redirecting to resize (#22515) * #22463 Support old scale redirecting to resize * #22463 update expected content-type * Revert "#22463 update expected content-type" This reverts commit abebd0e. * #22463 debugging filters * More logging * Logging * Testing * Undo logging * #22489 Remove "Beta" from the block editor field name * Fix red * #22552 fix Log Filter: The console gets blank after switching log files (#22557) * Postman tests fixes (#22555) * Adding duration to postman collection run * Fixing and improving postman tests * Directly removing GITHUB context displaying * Enabling workflow steps * #22501 Drag-N-Drop Navigation reorder not affecting changes to nav menu In the previous release, we updated the `Folder` class to stop inheriting from `Inode`. The menu reordering code was relying on that, so it stopped working after the change. We're now passing down the Identifier to make it work as expected. * Renabling chain of jobs-steps at main workflow * Fixing typo * #22554 22149 Handle no-license and no-endpoints scenarios and other fixes (#22561) * #22501 Missing change from previous PR. (#22564) * Postman improvements (#22565) * Tuning tests in general * nop * #22338 Fixed dupe widgets * fix: prevent widgets from being repeated * fix: comment * CI: bumps version to 22.7.0-rc.24 [skip ci] * Fix annotations (#22572) * Fix annotations * Update HostFactoryImpl.java * Exclude HostAPITest from mainsuite Co-authored-by: freddyucv <[email protected]> * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. (#22576) * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Code Review changes. * New starter generated. Version: 20220713 (#22568) Co-authored-by: nollymar <[email protected]> * new empty starter (#22586) * CI: bumps version to 22.7.0-rc.25 [skip ci] * CI: bumps version to 22.7.0-rc.26 [skip ci] * Trigger dotcms-ui build in 22.07 (#22591) * Revert "Trigger dotcms-ui build in 22.07 (#22591)" This reverts commit 7c7ed00. * CI: bumps version to 22.7.0-rc.27 [skip ci] * Trigger dotcms-ui build in 22.07 with copy prepare to fix (#22592) * Trigger dotcms-ui build * CI: bumps version to 22.7.0-rc.28 [skip ci] * Notify to slack dotcms-ui build (#22595) * Fix the slack notification in dotcms-ui * CI: bumps version to 22.7.0-rc.29 [skip ci] * #20840 System Workflow should be used as default when no license is set * #20840 adding changes when no license shows the system workflow * #20840 refactoring the unit test * Revert changes (#22505) * Update README.md * Update README.md * (#22605): Fix of wrong keyword to replace when running migration task. (#22613) * #22168 Correct the generated REST URLs from Content Search 'Show Query' (#22590) (#22620) * #22615 respect FE roles true (#22616) * #22615 respect FE roles true * #22615 Postman test * #22559 Do respond pages in case of 404. Postman added (#22575) * #22559 Do respond pages in case of 404. Postman added * Update VanityURL.postman_collection.json * Update postman * disable cookies * Update VanityURL.postman_collection.json * #22559 missing asset in bundle * #22164 Whitelist blocks (#22547) * Update master bumped version for dotcms-ui and dotcms-webcomponents * CI: bumps version to 22.8.0-next.6 [skip ci] * progress * feedback and progess * limit the dotImage block and also D&D of images * remove deprecated defaultOptions * refactor * refactor * spaces * refactor feedback * refactor feedback Co-authored-by: victoralfaro-dotcms <[email protected]> * #21959 : Adding an optional EMA Token to EMA URL. (#22560) The reason behind this approach is to verify that every EMA URL is valid and will be handled by dotCMS. If the token is present, it will be validated against the data returned by the EMA. If the same token is not present, the request will fail. * #22204 : Notify the UI about bad request errors when changing password. (#22569) * #22204 : Notify the UI about bad request errors when changing password. We need to use the existing message key to report the appropriate error when an invalid password is being passed down. * #22204 : Adjusting password RegEx to include missing characters, and increase minimum length from 6 to 8 characters. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Fixing Unit Test. * Fixing dependency bundler test test (#22641) * Fixing test * Fixing test * Issue 22083 page cache 2 (#22637) * #22083 simplifying page cache: * #22083 simplifying page cache: Co-authored-by: Will Ezell <[email protected]> * #21959 Add an EMA token/key when initing a EMA environment ### Proposed Changes * Fixing a code issue. Adding more Javadoc. ### Checklist - [ ] Tests * (#22510): Increasing max_locks_per_transaction to avoid shared memory errors on both integration and postman tests (#22570) Removing postman dup tests * #18715 PP Filters: Allow users to specify the order filters appear in the list * #18715 : Allow users to specify the order PP Filters appear in the list. - Added an optional "sort" property that can be used to specify filter ordering. A default sort value of 1000 is used if not present. Filters with the same sort value fall back to using alphabetical sorting. - Moved business logic from the `PushPublishFiltersInitializer` to the `PublisherAPIImpl`, where it should be. - Moved business logic from the `PushPublishFilterResource` REST Endpoint into the `PublisherAPIImpl`, where it should be. - Adjusted existing Integration Tests, and added new ones. * #18715 : Adding code review changes. * #18715 : Adding Code Review changes requested by Jonathan Sanchez * #18715 : Adding Code Review changes requested by Jonathan Sanchez * Disable DNS validation for failing IT (#22654) * Issue 22512 disallow anonymous (#22645) * #22644 changing defaults * #22644 changing defaults * #22168 Using right URL in curl statement (#22661) * Removing not required log * #18715 PP Filters: Allow users to specify the order filters appear in the list (#22662) * CI: bumps version to 22.7.0-rc.30 [skip ci] * #22168 Add the API link back in the show query window (#22665) * #22083 fixes it (#22655) * #22083 fixes it * #22083 more fixing * #22083 renaming class * Fixing content handler test (#22651) * Fixing ContentHandlerTest * Running test * Removing lines * #18715 PP Filters: Allow users to specify the order filters appear in the list * #20840 fixing test (#22680) Co-authored-by: Will Ezell <[email protected]> * Latest changes in tail log that included filter and highlight features were rolled back (#22688) Co-authored-by: nollymar <[email protected]> * Fixing test (#22690) * Fixing test (#22675) * Fixing test * Fixing test * Adding log * Fixing test * Turn into debug log * #22644 Add postman test (#22676) * #22644 Add postman test * #22644 disable cookies for test * Undo changes for master * Update MainSuite.java * fix files with new lint ruels Co-authored-by: victoralfaro-dotcms <[email protected]> Co-authored-by: alfredo-dotcms <[email protected]> Co-authored-by: Freddy Rodriguez <[email protected]> Co-authored-by: Humberto Morera <[email protected]> Co-authored-by: Jose Castro <[email protected]> Co-authored-by: Rafael Velazco <[email protected]> Co-authored-by: Nollymar Longa <[email protected]> Co-authored-by: nollymar <[email protected]> Co-authored-by: Freddy Montes <[email protected]> Co-authored-by: Jonathan <[email protected]> Co-authored-by: Will Ezell <[email protected]> Co-authored-by: Arcadio Quintero <[email protected]>

swicken-dotcms added Type : Defect Severity : Support Requested labels May 4, 2022

erickgonzalez added the Severity : Next Priority label May 17, 2022

swicken-dotcms added Severity : Support Priority and removed Severity : Next Priority labels May 26, 2022

freddyucv self-assigned this Jun 29, 2022

freddyucv pushed a commit that referenced this issue Jun 30, 2022

#22149 Adding into the bundle just the selected user when one exists

5c7ad12

freddyucv pushed a commit that referenced this issue Jul 1, 2022

#22149 Change Menu label wheter user is selected or not

6c2f5fb

freddyucv pushed a commit that referenced this issue Jul 5, 2022

#22149 Change message when any user is selected

0251c87

freddyucv pushed a commit that referenced this issue Jul 5, 2022

#22149 Change menu message when no User is Selected

c9b0890

freddyucv pushed a commit that referenced this issue Jul 5, 2022

Revert "#22149 Change message when any user is selected"

42f7024

This reverts commit 0251c87.

freddyucv pushed a commit that referenced this issue Jul 5, 2022

Revert "#22149 Change Menu label wheter user is selected or not"

c13cf02

This reverts commit 6c2f5fb.

freddyucv pushed a commit that referenced this issue Jul 5, 2022

#22149 Add Id to menu Item

795bac7

freddyucv added the Doc : Needs Doc label Jul 5, 2022

dsilvam added Merged QA : Needs Internal Release : 22.08 labels Jul 5, 2022

dsilvam unassigned freddyucv Jul 5, 2022

erickgonzalez removed the Severity : Support Priority label Jul 6, 2022

erickgonzalez linked a pull request Jul 6, 2022 that will close this issue

#22149 Adding into the bundle just the selected user when one exists #22504

Merged

dsilvam linked a pull request Jul 8, 2022 that will close this issue

#22508 Add User into the Manifest #22511

Merged

oidacra assigned oidacra and unassigned oidacra Jul 12, 2022

dsilvam linked a pull request Jul 12, 2022 that will close this issue

#22554 22149 Handle no-license and no-endpoints scenarios and other f… #22561

Merged

oidacra self-assigned this Jul 25, 2022

victoralfaro-dotcms self-assigned this Jul 25, 2022

victoralfaro-dotcms added QA : Passed Internal and removed QA : Needs Internal labels Jul 25, 2022

victoralfaro-dotcms unassigned oidacra and victoralfaro-dotcms Jul 25, 2022

bryanboza added the QA : Approved label Jul 28, 2022

dsilvam closed this as completed Jul 28, 2022

erickgonzalez added LTS: Needs Backport Ticket that will be added to LTS Next LTS Release Release : 21.06.11 Included in LTS patch release 21.06.11 labels Aug 12, 2022

dotCMSJack added the Severity : CS Priority label Aug 16, 2022

erickgonzalez added a commit that referenced this issue Aug 22, 2022

#22149 include in 21.06.11

e8d92b1

erickgonzalez added the Release : 5.3.8.14 Included in LTS patch release 5.3.8.14 label Aug 31, 2022

erickgonzalez added a commit that referenced this issue Sep 1, 2022

#22149 include in 5.3.8.14

ce9c974

erickgonzalez added Release : 22.03.3 Included in LTS patch release 22.03.3 and removed Severity : Support Requested LTS: Needs Backport Ticket that will be added to LTS labels Oct 25, 2022

erickgonzalez added a commit that referenced this issue Oct 25, 2022

#22149 include in 22.03.3

faebf5b

erickgonzalez removed the Severity : CS Priority label Oct 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The push publish button in the expansion menu on the users portlet doesn't just push the selected user, it pushes all users #22149

The push publish button in the expansion menu on the users portlet doesn't just push the selected user, it pushes all users #22149

swicken-dotcms commented May 4, 2022

freddyucv commented Jul 1, 2022 •

edited

Loading

freddyucv commented Jul 5, 2022

hmoreras commented Jul 12, 2022

dsilvam commented Jul 12, 2022

victoralfaro-dotcms commented Jul 25, 2022 •

edited

Loading

bryanboza commented Jul 28, 2022

The push publish button in the expansion menu on the users portlet doesn't just push the selected user, it pushes all users #22149

The push publish button in the expansion menu on the users portlet doesn't just push the selected user, it pushes all users #22149

Comments

swicken-dotcms commented May 4, 2022

freddyucv commented Jul 1, 2022 • edited Loading

freddyucv commented Jul 5, 2022

hmoreras commented Jul 12, 2022

dsilvam commented Jul 12, 2022

victoralfaro-dotcms commented Jul 25, 2022 • edited Loading

bryanboza commented Jul 28, 2022

freddyucv commented Jul 1, 2022 •

edited

Loading

victoralfaro-dotcms commented Jul 25, 2022 •

edited

Loading