#22554 22149 Handle no-license and no-endpoints scenarios and other f… #22561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabrizzio-dotCMS
approved these changes
Jul 12, 2022
hmoreras
approved these changes
Jul 12, 2022
Closed
This was
linked to
issues
Jul 12, 2022
dsilvam
added a commit
that referenced
this pull request
Jul 19, 2022
* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 22.07, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-22.07 * Update branch in git submodule to release-22.07 * CI: bumps version to 22.7.0-rc.11 [skip ci] * #22496 fix tail log Whitespaces are printed sometimes at the beginning of the lines (#22538) * #22508 Add User into the Manifest (#22511) * #22508 Add User into the Manifest * #22149 Change Menu label wheter user is selected or not * #22149 Change message when any user is selected * Revert "#22149 Change message when any user is selected" This reverts commit 0251c87. * Revert "#22149 Change Menu label wheter user is selected or not" This reverts commit 6c2f5fb. * #22508 Testing and Fixing Manifest bug * Fixing test * Adding javadoc * Removing NotNull * #22463 Support old scale redirecting to resize (#22515) * #22463 Support old scale redirecting to resize * #22463 update expected content-type * Revert "#22463 update expected content-type" This reverts commit abebd0e. * #22463 debugging filters * More logging * Logging * Testing * Undo logging * #22489 Remove "Beta" from the block editor field name * Fix red * #22552 fix Log Filter: The console gets blank after switching log files (#22557) * Postman tests fixes (#22555) * Adding duration to postman collection run * Fixing and improving postman tests * Directly removing GITHUB context displaying * Enabling workflow steps * #22501 Drag-N-Drop Navigation reorder not affecting changes to nav menu In the previous release, we updated the `Folder` class to stop inheriting from `Inode`. The menu reordering code was relying on that, so it stopped working after the change. We're now passing down the Identifier to make it work as expected. * Renabling chain of jobs-steps at main workflow * Fixing typo * #22554 22149 Handle no-license and no-endpoints scenarios and other fixes (#22561) * #22501 Missing change from previous PR. (#22564) * Postman improvements (#22565) * Tuning tests in general * nop * #22338 Fixed dupe widgets * fix: prevent widgets from being repeated * fix: comment * CI: bumps version to 22.7.0-rc.24 [skip ci] * Fix annotations (#22572) * Fix annotations * Update HostFactoryImpl.java * Exclude HostAPITest from mainsuite Co-authored-by: freddyucv <[email protected]> * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. (#22576) * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Code Review changes. * Update gradle.properties * Update release-process.yml Co-authored-by: victoralfaro-dotcms <[email protected]> Co-authored-by: alfredo-dotcms <[email protected]> Co-authored-by: Freddy Rodriguez <[email protected]> Co-authored-by: Humberto Morera <[email protected]> Co-authored-by: Jose Castro <[email protected]> Co-authored-by: Rafael Velazco <[email protected]>
dsilvam
added a commit
that referenced
this pull request
Jul 26, 2022
* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 22.07, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-22.07 * Update branch in git submodule to release-22.07 * CI: bumps version to 22.7.0-rc.11 [skip ci] * #22496 fix tail log Whitespaces are printed sometimes at the beginning of the lines (#22538) * #22508 Add User into the Manifest (#22511) * #22508 Add User into the Manifest * #22149 Change Menu label wheter user is selected or not * #22149 Change message when any user is selected * Revert "#22149 Change message when any user is selected" This reverts commit 0251c87. * Revert "#22149 Change Menu label wheter user is selected or not" This reverts commit 6c2f5fb. * #22508 Testing and Fixing Manifest bug * Fixing test * Adding javadoc * Removing NotNull * #22463 Support old scale redirecting to resize (#22515) * #22463 Support old scale redirecting to resize * #22463 update expected content-type * Revert "#22463 update expected content-type" This reverts commit abebd0e. * #22463 debugging filters * More logging * Logging * Testing * Undo logging * #22489 Remove "Beta" from the block editor field name * Fix red * #22552 fix Log Filter: The console gets blank after switching log files (#22557) * Postman tests fixes (#22555) * Adding duration to postman collection run * Fixing and improving postman tests * Directly removing GITHUB context displaying * Enabling workflow steps * #22501 Drag-N-Drop Navigation reorder not affecting changes to nav menu In the previous release, we updated the `Folder` class to stop inheriting from `Inode`. The menu reordering code was relying on that, so it stopped working after the change. We're now passing down the Identifier to make it work as expected. * Renabling chain of jobs-steps at main workflow * Fixing typo * #22554 22149 Handle no-license and no-endpoints scenarios and other fixes (#22561) * #22501 Missing change from previous PR. (#22564) * Postman improvements (#22565) * Tuning tests in general * nop * #22338 Fixed dupe widgets * fix: prevent widgets from being repeated * fix: comment * CI: bumps version to 22.7.0-rc.24 [skip ci] * Fix annotations (#22572) * Fix annotations * Update HostFactoryImpl.java * Exclude HostAPITest from mainsuite Co-authored-by: freddyucv <[email protected]> * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. (#22576) * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Code Review changes. * New starter generated. Version: 20220713 (#22568) Co-authored-by: nollymar <[email protected]> * new empty starter (#22586) * CI: bumps version to 22.7.0-rc.25 [skip ci] * CI: bumps version to 22.7.0-rc.26 [skip ci] * Trigger dotcms-ui build in 22.07 (#22591) * Revert "Trigger dotcms-ui build in 22.07 (#22591)" This reverts commit 7c7ed00. * CI: bumps version to 22.7.0-rc.27 [skip ci] * Trigger dotcms-ui build in 22.07 with copy prepare to fix (#22592) * Trigger dotcms-ui build * CI: bumps version to 22.7.0-rc.28 [skip ci] * Notify to slack dotcms-ui build (#22595) * Fix the slack notification in dotcms-ui * CI: bumps version to 22.7.0-rc.29 [skip ci] * #20840 System Workflow should be used as default when no license is set * #20840 adding changes when no license shows the system workflow * #20840 refactoring the unit test * Revert changes (#22505) * Update README.md * Update README.md * (#22605): Fix of wrong keyword to replace when running migration task. (#22613) * #22168 Correct the generated REST URLs from Content Search 'Show Query' (#22590) (#22620) * #22615 respect FE roles true (#22616) * #22615 respect FE roles true * #22615 Postman test * #22559 Do respond pages in case of 404. Postman added (#22575) * #22559 Do respond pages in case of 404. Postman added * Update VanityURL.postman_collection.json * Update postman * disable cookies * Update VanityURL.postman_collection.json * #22559 missing asset in bundle * Leave values for master Co-authored-by: victoralfaro-dotcms <[email protected]> Co-authored-by: alfredo-dotcms <[email protected]> Co-authored-by: Freddy Rodriguez <[email protected]> Co-authored-by: Humberto Morera <[email protected]> Co-authored-by: Jose Castro <[email protected]> Co-authored-by: Rafael Velazco <[email protected]> Co-authored-by: Nollymar Longa <[email protected]> Co-authored-by: nollymar <[email protected]> Co-authored-by: Freddy Montes <[email protected]> Co-authored-by: Jonathan <[email protected]>
dsilvam
added a commit
that referenced
this pull request
Aug 9, 2022
* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 22.07, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-22.07 * Update branch in git submodule to release-22.07 * CI: bumps version to 22.7.0-rc.11 [skip ci] * #22496 fix tail log Whitespaces are printed sometimes at the beginning of the lines (#22538) * #22508 Add User into the Manifest (#22511) * #22508 Add User into the Manifest * #22149 Change Menu label wheter user is selected or not * #22149 Change message when any user is selected * Revert "#22149 Change message when any user is selected" This reverts commit 0251c87. * Revert "#22149 Change Menu label wheter user is selected or not" This reverts commit 6c2f5fb. * #22508 Testing and Fixing Manifest bug * Fixing test * Adding javadoc * Removing NotNull * #22463 Support old scale redirecting to resize (#22515) * #22463 Support old scale redirecting to resize * #22463 update expected content-type * Revert "#22463 update expected content-type" This reverts commit abebd0e. * #22463 debugging filters * More logging * Logging * Testing * Undo logging * #22489 Remove "Beta" from the block editor field name * Fix red * #22552 fix Log Filter: The console gets blank after switching log files (#22557) * Postman tests fixes (#22555) * Adding duration to postman collection run * Fixing and improving postman tests * Directly removing GITHUB context displaying * Enabling workflow steps * #22501 Drag-N-Drop Navigation reorder not affecting changes to nav menu In the previous release, we updated the `Folder` class to stop inheriting from `Inode`. The menu reordering code was relying on that, so it stopped working after the change. We're now passing down the Identifier to make it work as expected. * Renabling chain of jobs-steps at main workflow * Fixing typo * #22554 22149 Handle no-license and no-endpoints scenarios and other fixes (#22561) * #22501 Missing change from previous PR. (#22564) * Postman improvements (#22565) * Tuning tests in general * nop * #22338 Fixed dupe widgets * fix: prevent widgets from being repeated * fix: comment * CI: bumps version to 22.7.0-rc.24 [skip ci] * Fix annotations (#22572) * Fix annotations * Update HostFactoryImpl.java * Exclude HostAPITest from mainsuite Co-authored-by: freddyucv <[email protected]> * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. (#22576) * #21129 : Not requiring a value for the folder title when `Show On Menu` property is enabled. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Adding more language files. * #21129 : Code Review changes. * New starter generated. Version: 20220713 (#22568) Co-authored-by: nollymar <[email protected]> * new empty starter (#22586) * CI: bumps version to 22.7.0-rc.25 [skip ci] * CI: bumps version to 22.7.0-rc.26 [skip ci] * Trigger dotcms-ui build in 22.07 (#22591) * Revert "Trigger dotcms-ui build in 22.07 (#22591)" This reverts commit 7c7ed00. * CI: bumps version to 22.7.0-rc.27 [skip ci] * Trigger dotcms-ui build in 22.07 with copy prepare to fix (#22592) * Trigger dotcms-ui build * CI: bumps version to 22.7.0-rc.28 [skip ci] * Notify to slack dotcms-ui build (#22595) * Fix the slack notification in dotcms-ui * CI: bumps version to 22.7.0-rc.29 [skip ci] * #20840 System Workflow should be used as default when no license is set * #20840 adding changes when no license shows the system workflow * #20840 refactoring the unit test * Revert changes (#22505) * Update README.md * Update README.md * (#22605): Fix of wrong keyword to replace when running migration task. (#22613) * #22168 Correct the generated REST URLs from Content Search 'Show Query' (#22590) (#22620) * #22615 respect FE roles true (#22616) * #22615 respect FE roles true * #22615 Postman test * #22559 Do respond pages in case of 404. Postman added (#22575) * #22559 Do respond pages in case of 404. Postman added * Update VanityURL.postman_collection.json * Update postman * disable cookies * Update VanityURL.postman_collection.json * #22559 missing asset in bundle * #22164 Whitelist blocks (#22547) * Update master bumped version for dotcms-ui and dotcms-webcomponents * CI: bumps version to 22.8.0-next.6 [skip ci] * progress * feedback and progess * limit the dotImage block and also D&D of images * remove deprecated defaultOptions * refactor * refactor * spaces * refactor feedback * refactor feedback Co-authored-by: victoralfaro-dotcms <[email protected]> * #21959 : Adding an optional EMA Token to EMA URL. (#22560) The reason behind this approach is to verify that every EMA URL is valid and will be handled by dotCMS. If the token is present, it will be validated against the data returned by the EMA. If the same token is not present, the request will fail. * #22204 : Notify the UI about bad request errors when changing password. (#22569) * #22204 : Notify the UI about bad request errors when changing password. We need to use the existing message key to report the appropriate error when an invalid password is being passed down. * #22204 : Adjusting password RegEx to include missing characters, and increase minimum length from 6 to 8 characters. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Adding the rest of language files. * #22204 : Fixing Unit Test. * Fixing dependency bundler test test (#22641) * Fixing test * Fixing test * Issue 22083 page cache 2 (#22637) * #22083 simplifying page cache: * #22083 simplifying page cache: Co-authored-by: Will Ezell <[email protected]> * #21959 Add an EMA token/key when initing a EMA environment ### Proposed Changes * Fixing a code issue. Adding more Javadoc. ### Checklist - [ ] Tests * (#22510): Increasing max_locks_per_transaction to avoid shared memory errors on both integration and postman tests (#22570) Removing postman dup tests * #18715 PP Filters: Allow users to specify the order filters appear in the list * #18715 : Allow users to specify the order PP Filters appear in the list. - Added an optional "sort" property that can be used to specify filter ordering. A default sort value of 1000 is used if not present. Filters with the same sort value fall back to using alphabetical sorting. - Moved business logic from the `PushPublishFiltersInitializer` to the `PublisherAPIImpl`, where it should be. - Moved business logic from the `PushPublishFilterResource` REST Endpoint into the `PublisherAPIImpl`, where it should be. - Adjusted existing Integration Tests, and added new ones. * #18715 : Adding code review changes. * #18715 : Adding Code Review changes requested by Jonathan Sanchez * #18715 : Adding Code Review changes requested by Jonathan Sanchez * Disable DNS validation for failing IT (#22654) * Issue 22512 disallow anonymous (#22645) * #22644 changing defaults * #22644 changing defaults * #22168 Using right URL in curl statement (#22661) * Removing not required log * #18715 PP Filters: Allow users to specify the order filters appear in the list (#22662) * CI: bumps version to 22.7.0-rc.30 [skip ci] * #22168 Add the API link back in the show query window (#22665) * #22083 fixes it (#22655) * #22083 fixes it * #22083 more fixing * #22083 renaming class * Fixing content handler test (#22651) * Fixing ContentHandlerTest * Running test * Removing lines * #18715 PP Filters: Allow users to specify the order filters appear in the list * #20840 fixing test (#22680) Co-authored-by: Will Ezell <[email protected]> * Latest changes in tail log that included filter and highlight features were rolled back (#22688) Co-authored-by: nollymar <[email protected]> * Fixing test (#22690) * Fixing test (#22675) * Fixing test * Fixing test * Adding log * Fixing test * Turn into debug log * #22644 Add postman test (#22676) * #22644 Add postman test * #22644 disable cookies for test * Undo changes for master * Update MainSuite.java * fix files with new lint ruels Co-authored-by: victoralfaro-dotcms <[email protected]> Co-authored-by: alfredo-dotcms <[email protected]> Co-authored-by: Freddy Rodriguez <[email protected]> Co-authored-by: Humberto Morera <[email protected]> Co-authored-by: Jose Castro <[email protected]> Co-authored-by: Rafael Velazco <[email protected]> Co-authored-by: Nollymar Longa <[email protected]> Co-authored-by: nollymar <[email protected]> Co-authored-by: Freddy Montes <[email protected]> Co-authored-by: Jonathan <[email protected]> Co-authored-by: Will Ezell <[email protected]> Co-authored-by: Arcadio Quintero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix didn't handle the scenario of no license or no endpoints configured.
It was also depending on right clicking on a user, which is not guaranteed to happen.
Also a PP dialog without date filter is used when pp-ing / adding-to-bundle a single user.