Issue 12999 delete content types #13214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nollymar
reviewed
Dec 19, 2017
| * @param container Container with the new changes to be persisted | ||
| */ | ||
| private void saveContainerStructures (ActionRequest req, Container currentContainer, Container container) | ||
| throws DotDataException, DotSecurityException { |
There was a problem hiding this comment.
The logic on this code can be optimized keeping a map for oldContainerStructures, then filter to exclude newContainerStructures (https://www.mkyong.com/java8/java-8-filter-a-map-examples/). With the resulting map you can delete in batch. I think it's a faster and less verbose implementation
nollymar
reviewed
Dec 19, 2017
| } | ||
|
|
||
| @NotNull | ||
| private static MultiTree getMultiTreeFields(Map<String, String> map) { |
There was a problem hiding this comment.
A MultitreeTransformer can be implemented instead. Take a look at https://github.com/dotCMS/core/blob/master/dotCMS/src/main/java/com/dotmarketing/portlets/templates/transform/FolderTransformer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.