Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Delete Content types in current master. #12999

Closed
joseorsini opened this issue Nov 7, 2017 · 5 comments
Closed

Cannot Delete Content types in current master. #12999

joseorsini opened this issue Nov 7, 2017 · 5 comments

Comments

@joseorsini
Copy link
Contributor

joseorsini commented Nov 7, 2017

As a follow up for #12716, additional tests made:

  • Created a Test Content 001 Content Type, with only a Title Field.
  • Under Large-1 Container on demo site, add this content type and print $!{title} value.
  • Create a page using Quest - 1 Column.
  • On Edit Mode, add a Test Content 001 content under the main container of this page. You should see printed the Content Title on this page.
  • Attempt to delete the content type, which calls the destroy() method on ContentletAPI and then destroyContentlets() (the one that fails in regression tests). This shows on backend view:

screen shot 2017-11-07 at 8 47 30 am

  • Go ahead and remove the Test Content 001 content from Large-1 container.
  • Open again the page in Edit Mode. Content is still there, despite the container should not print contents from this content type. Nothing is printed from this content, though.

screen shot 2017-11-07 at 8 55 33 am

this is the current definition of container. See that Test Content 001 content type is not part of the code definition anymore:

screen shot 2017-11-07 at 9 01 04 am

  • Try again to delete the content type. Same error as above

If we try to delete a content type like Call to Action, or the same content type above without following the steps for adding contents to pages/containers, we get this error

An unexpected system error occurred. 
com.dotmarketing.exception.DotDataException: An error occurred when  saving a system event with ID: [null]: Cannot find type adapter for  class 
com.dotcms.contenttype.model.type.ImmutableSimpleContentType

Stacktrace: https://gist.github.com/joseorsini/17f2fc375da89f52a503e9a4461817af

@joseorsini
Copy link
Contributor Author

It makes sense that a content type deletion complains about an old container-contenttype relationship, however, it exists on an old version of the container itself (these relationships are versionable). Still, current live/working version of container does not reference this content type, so we should be able to delete the content type instead of going to each old version of the container and inspect which one refers to this content type.

Additionally, multi-tree relationships are not versionable, so if a current version of a container drops support for a content type, we shouldn't keep those records on this tree IMHO.

@dsilvam dsilvam modified the milestones: Rex Current, Rex Next Nov 7, 2017
@dsilvam dsilvam modified the milestones: Rex Current, Rex Next Dec 5, 2017
acurionedotcms added a commit that referenced this issue Dec 14, 2017
acurionedotcms added a commit that referenced this issue Dec 14, 2017
@acurionedotcms acurionedotcms removed their assignment Dec 14, 2017
acurionedotcms added a commit that referenced this issue Dec 19, 2017
* #12999 - Cannot delete content types that were used in containers

* #12999 - Verbiage fix

* #12999 - Remove MultiTree when updating Containers and Structures are removed

* #12999 - Fixes after code review

* #12999 - Replace HQL by Native query as requested by Daniel

* #12999 - Conflict Fixes after merge with master

* #12999 - Changes as per SonarQube, reduce complexity

* #12999 - Changes as per SonarQube, reduce complexity

* #12999 - Fix in MultiTree getMultiTreeFields
acurionedotcms added a commit that referenced this issue Dec 19, 2017
acurionedotcms added a commit that referenced this issue Dec 19, 2017
jgambarios pushed a commit that referenced this issue Dec 21, 2017
* #12999 - Added MultiTree Transformer

* #12999 - Fix after code review

* #12999 - SonarQube review
@jgambarios
Copy link
Contributor

PR: #13242

jgambarios added a commit that referenced this issue Dec 21, 2017
@jgambarios
Copy link
Contributor

jgambarios commented Dec 21, 2017

By Wills request we reverted #13242 with this pull request #13255
We are waiting to the changes on this pull request #13193 to be merge in order to re-apply the changes made on #13242

@jgambarios jgambarios removed the Merged label Dec 21, 2017
@dsilvam dsilvam modified the milestones: Rex Current , Rex Next Jan 16, 2018
@acurionedotcms acurionedotcms self-assigned this Jan 22, 2018
dsilvam pushed a commit that referenced this issue Jan 22, 2018
* #12999 - Added MultiTree Transformer

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes
@shaydotcms shaydotcms assigned shaydotcms and unassigned shaydotcms Jan 24, 2018
@DeanGonzalez DeanGonzalez self-assigned this Jan 29, 2018
@bryanboza
Copy link
Contributor

Fixed, tested in the last master and now we are able to delete content types without problems

brentgriffin pushed a commit that referenced this issue Jan 30, 2018
* Updating commit reference for src/main/enterprise

* #13309 - Changes in the Upsert Command for Postgres -9.4 (#13403)

* #13309 - Changes in the Upsert Command for Postgres -9.4

* #13309 - Changes in the Upsert Command for Postgres -9.4

* Can't save new containers in a layout (#13377)

* Can't save new containers in a layout

* refactoring

* refactoring

* merge

* doing constructor public again

* refactoring

* refactoring

* #13196 (#13405)

* Wrong type #13196 (#13406)

* Issue 13352 dnd on workflow (#13382)

* #13352 adding drag and drop to workflow builder

* #13352 cool new hover trick

* #13352 we didn't need api changed

* #13352

* Add message key (#13412)

* #12991 Need to add action of push publish to content types

* #13236 Edit contentlets in page (#13400)

js changes

* bring back download data/assets changes (#13422)

* #13395 CopyContentlet done (#13415)

* Fix more jenkins tests (#13427)

* Updating commit reference for src/main/enterprise

* PermissionAPITest: converted from functional to integration
RoleAjax: remove unused user. Can now be tested with server down
UserAPITest: fix workflow issues
FolderAPITest: fix workflow issues
LinkFactoryTest: fix workflow issues
ContainerFactoryImpl: Reading version info from api instead of only cache.

* #13410 MSSQL Task 04315 Upgrade Fix (#13423)

* #13410 MSSQL Task 04315 Upgrade Fix

* #13410 MSSQL Task 04315 Upgrade Fix

* #13321: Clearing cache to force DB search (#13431)

* Remove permission tests from alltestsuite (#13434)

* Updating commit reference for src/main/enterprise

* PermissionAPITest: converted from functional to integration
RoleAjax: remove unused user. Can now be tested with server down
UserAPITest: fix workflow issues
FolderAPITest: fix workflow issues
LinkFactoryTest: fix workflow issues
ContainerFactoryImpl: Reading version info from api instead of only cache.

* Remove ITest from AllTestSuite.

* #13424 fixes the mysql lockup issue (#13426)

* #13424 fixes the mysql lockup issue

* #13424 closes the preparedstatement

* #13241 rethrow the original exception (#13416)

* Updating commit reference for src/main/enterprise

* Fix TreeTransformer for Oracle. (#13439)

* #13433 bring back Backup Data/Assets functionality (#13442)

* Added new starter

* #13321: Avoiding factory method with API find call inside (#13443)

* #13429 (#13432)

* Updating commit reference for src/main/enterprise

* Added new starter

* Clean folderapitest rename (#13456)

* Fix TreeTransformer for Oracle.

* Dont mess with cache in the test. FolderAPITest.rename

* #13384 - Delete Template dependencies popup should display Template Title (#13455)

* Workflows tests fixes (#13460)

* Workflows tests fixes

* Workflows tests fixes

* Workflows tests - Adding missing condition (#13461)

* #13196 fixing ut for oracle (#13463)

* #13196 fixes for upgrade task for msssql (#13462)

* Issue 12991 need to add actions push publish content types (#13444)

* issue #12991 push publish content types message keys

* #12991 push publish content types actions message keys

* #12991 push publish content types message keys

* Issue 13457 (#13465)

* #13457: Remove unused logic

* #13457: Add copyTemplate integration test

* #13419: Prevent NPE by avoiding Layout parsing when Template not drawn (#13458)

* #13419: Prevent NPE by avoiding Layout parsing when Template not drawed

* #13419: Adding Will's logic from no-code branch

* #12999 - Added MultiTree Transformer (#13438)

* #12999 - Added MultiTree Transformer

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* Fix condition check for user api test. More Logging. (#13473)

* #13474 Include lang properties changes. (#13476)

* Workflows tests - Fixing permissions (#13477)

* error common label (#13467)

* Include working:true in es query for reindexing content after updating user. Use isInodeIndex with live=false. (#13479)

* #13390 cherry-pick the email fix (#13484)

* Updating commit reference for src/main/enterprise

* http://#13295 set sidebar width in edit layout - Message keys (#13480)

* Include more logging for FolderAPITest.delete (#13488)

* Issue rest multiple binaries (#13472)

* #11620

* #11613

* #13466 - Fixes in Update System Folder when System folder has been re… (#13486)

* #13466 - Fixes in Update System Folder when System folder has been renamed

* #13466 - Fixes in Update System Folder when System folder has been renamed

* Folderapitest rename logging (#13491)

* Include more logging for FolderAPITest.delete

* more logging.

* Adding missing validation (#13489)

* Adding missing validation

* Fixing Typo

* Logging for FolderAPITest.delete

* UserAPITest.delete:Load Identifiers from db to avoid cache race conditions.

* Issue 13336 (#13487)

* #13336 remove CMIS

* #13336 remove commented code

* #13336 changes DBSearch

* #13336 revert changes DBSearch

* #13336 missing assignment

* Updating commit reference for src/main/enterprise

* Issue 13429 missing commit tika lowercase (#13501)

* #13429

* missing lowercase

* ESUtils: include case for text with whitespace (#13499)

ESUtilsTest: test for all special chars and whitespace

* Updating commit reference for src/main/enterprise

* #13375 - Folder API - Incorrect Query causing cartesian product and o… (#13493)

* #13375 - Folder API - Incorrect Query causing cartesian product and out of memory or closed resultsets errors

* #13375 - Folder API - Incorrect Query causing cartesian product and out of memory or closed resultsets errors

* #10604 add hover options for span tags in website browser (#13490)

* #12991 push publish content types - Messages keys (#13500)

* Issue 13502 npe on deleted bundle (#13503)

* #13429

* fixes #13502

* Use new ami (#13511)

* ContentResource: Pass value of REST_API_CONTENT_ALLOW_FRONT_END_SAVIN… (#13510)

* ContentResource: Pass value of REST_API_CONTENT_ALLOW_FRONT_END_SAVING to methods to find cats by key or name
ContentResourceTest: Added two tests for both cases (true/false) for REST_API_CONTENT_ALLOW_FRONT_END_SAVING
when saving content via REST API with anonymous user

* #12150 Correct test name.

* #12150 Code review changes.

* Update ami jenkins (#13512)

* Use new ami

* New AMI for jenkins continuous tests.

* Include isInodeIndexed in test.

* Issue 13469 workflow multi lang (#13509)

* #13469 multi language support for workflow task

* #13469 Adding the multi language step/action workflows

* #13469 codacy feedback

* Issue 11265 create 4 eyes workflow actionlet (#13366)

* #11265 : Adding initial version of the 4-Eyes actionlet.

* #11265 : Adding initial version of the 4-Eyes actionlet.

* #11265 :

- Wrapping up changes in the 4-eyes approval actionlet class.
- Adding utility class for common-use methods in actionlets.

* #11265 : Adding new type of actionlet parameter that includes validation of role keys.

* #11265 : Codacy and Sonar code changes.

* #11265 : More Codacy and Sonar code changes.

* #11265 : First draft of integration test. Fixing exception throws where the original exception was being swallowed.

* #11265 : Adding more tests to the four-eye sub-action integration test.

* #13333 need to add action of add to bundle to content types - Adding message keus (#13516)

* Missing import

* Fix TreeTransformer and ContentletTransformer (#13518)

TreeTransformer: Use conversion utils instead of a class for Oracle.
TransformerLocator: create only TreeTransformer
ContentletTransformer: Use conversion utils to avoid classCastException in oracle

* #13375 fix starting up oracle, bc join never finds inode column (#13519)

* Remove invalid import.

* Fixing failing Jenkins tests. (#13517)

* changes to build docker image from gradle file - still need to upgrade gradle wrapper version

* cosmetic commit to build.gradle

* changed docker tags and added blank line at end of file

* upgraded gradle wrapper to 4.4.1

* 4.4.1 gradle wrapper

* added reference comment

* fixes #13527
dsilvam pushed a commit that referenced this issue Jan 30, 2018
* fixes #13435 - changed so rename only happens based on ARCHIVE_IMPORTED_LICENSE_PACKS being true.  Also logs failure if appropriate. (#13464)

* Issue 13527 build docker image from gradle build (#13529)

* Updating commit reference for src/main/enterprise

* #13309 - Changes in the Upsert Command for Postgres -9.4 (#13403)

* #13309 - Changes in the Upsert Command for Postgres -9.4

* #13309 - Changes in the Upsert Command for Postgres -9.4

* Can't save new containers in a layout (#13377)

* Can't save new containers in a layout

* refactoring

* refactoring

* merge

* doing constructor public again

* refactoring

* refactoring

* #13196 (#13405)

* Wrong type #13196 (#13406)

* Issue 13352 dnd on workflow (#13382)

* #13352 adding drag and drop to workflow builder

* #13352 cool new hover trick

* #13352 we didn't need api changed

* #13352

* Add message key (#13412)

* #12991 Need to add action of push publish to content types

* #13236 Edit contentlets in page (#13400)

js changes

* bring back download data/assets changes (#13422)

* #13395 CopyContentlet done (#13415)

* Fix more jenkins tests (#13427)

* Updating commit reference for src/main/enterprise

* PermissionAPITest: converted from functional to integration
RoleAjax: remove unused user. Can now be tested with server down
UserAPITest: fix workflow issues
FolderAPITest: fix workflow issues
LinkFactoryTest: fix workflow issues
ContainerFactoryImpl: Reading version info from api instead of only cache.

* #13410 MSSQL Task 04315 Upgrade Fix (#13423)

* #13410 MSSQL Task 04315 Upgrade Fix

* #13410 MSSQL Task 04315 Upgrade Fix

* #13321: Clearing cache to force DB search (#13431)

* Remove permission tests from alltestsuite (#13434)

* Updating commit reference for src/main/enterprise

* PermissionAPITest: converted from functional to integration
RoleAjax: remove unused user. Can now be tested with server down
UserAPITest: fix workflow issues
FolderAPITest: fix workflow issues
LinkFactoryTest: fix workflow issues
ContainerFactoryImpl: Reading version info from api instead of only cache.

* Remove ITest from AllTestSuite.

* #13424 fixes the mysql lockup issue (#13426)

* #13424 fixes the mysql lockup issue

* #13424 closes the preparedstatement

* #13241 rethrow the original exception (#13416)

* Updating commit reference for src/main/enterprise

* Fix TreeTransformer for Oracle. (#13439)

* #13433 bring back Backup Data/Assets functionality (#13442)

* Added new starter

* #13321: Avoiding factory method with API find call inside (#13443)

* #13429 (#13432)

* Updating commit reference for src/main/enterprise

* Added new starter

* Clean folderapitest rename (#13456)

* Fix TreeTransformer for Oracle.

* Dont mess with cache in the test. FolderAPITest.rename

* #13384 - Delete Template dependencies popup should display Template Title (#13455)

* Workflows tests fixes (#13460)

* Workflows tests fixes

* Workflows tests fixes

* Workflows tests - Adding missing condition (#13461)

* #13196 fixing ut for oracle (#13463)

* #13196 fixes for upgrade task for msssql (#13462)

* Issue 12991 need to add actions push publish content types (#13444)

* issue #12991 push publish content types message keys

* #12991 push publish content types actions message keys

* #12991 push publish content types message keys

* Issue 13457 (#13465)

* #13457: Remove unused logic

* #13457: Add copyTemplate integration test

* #13419: Prevent NPE by avoiding Layout parsing when Template not drawn (#13458)

* #13419: Prevent NPE by avoiding Layout parsing when Template not drawed

* #13419: Adding Will's logic from no-code branch

* #12999 - Added MultiTree Transformer (#13438)

* #12999 - Added MultiTree Transformer

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* #12999 - MultiTree Transformer test and fixes

* Fix condition check for user api test. More Logging. (#13473)

* #13474 Include lang properties changes. (#13476)

* Workflows tests - Fixing permissions (#13477)

* error common label (#13467)

* Include working:true in es query for reindexing content after updating user. Use isInodeIndex with live=false. (#13479)

* #13390 cherry-pick the email fix (#13484)

* Updating commit reference for src/main/enterprise

* http://#13295 set sidebar width in edit layout - Message keys (#13480)

* Include more logging for FolderAPITest.delete (#13488)

* Issue rest multiple binaries (#13472)

* #11620

* #11613

* #13466 - Fixes in Update System Folder when System folder has been re… (#13486)

* #13466 - Fixes in Update System Folder when System folder has been renamed

* #13466 - Fixes in Update System Folder when System folder has been renamed

* Folderapitest rename logging (#13491)

* Include more logging for FolderAPITest.delete

* more logging.

* Adding missing validation (#13489)

* Adding missing validation

* Fixing Typo

* Logging for FolderAPITest.delete

* UserAPITest.delete:Load Identifiers from db to avoid cache race conditions.

* Issue 13336 (#13487)

* #13336 remove CMIS

* #13336 remove commented code

* #13336 changes DBSearch

* #13336 revert changes DBSearch

* #13336 missing assignment

* Updating commit reference for src/main/enterprise

* Issue 13429 missing commit tika lowercase (#13501)

* #13429

* missing lowercase

* ESUtils: include case for text with whitespace (#13499)

ESUtilsTest: test for all special chars and whitespace

* Updating commit reference for src/main/enterprise

* #13375 - Folder API - Incorrect Query causing cartesian product and o… (#13493)

* #13375 - Folder API - Incorrect Query causing cartesian product and out of memory or closed resultsets errors

* #13375 - Folder API - Incorrect Query causing cartesian product and out of memory or closed resultsets errors

* #10604 add hover options for span tags in website browser (#13490)

* #12991 push publish content types - Messages keys (#13500)

* Issue 13502 npe on deleted bundle (#13503)

* #13429

* fixes #13502

* Use new ami (#13511)

* ContentResource: Pass value of REST_API_CONTENT_ALLOW_FRONT_END_SAVIN… (#13510)

* ContentResource: Pass value of REST_API_CONTENT_ALLOW_FRONT_END_SAVING to methods to find cats by key or name
ContentResourceTest: Added two tests for both cases (true/false) for REST_API_CONTENT_ALLOW_FRONT_END_SAVING
when saving content via REST API with anonymous user

* #12150 Correct test name.

* #12150 Code review changes.

* Update ami jenkins (#13512)

* Use new ami

* New AMI for jenkins continuous tests.

* Include isInodeIndexed in test.

* Issue 13469 workflow multi lang (#13509)

* #13469 multi language support for workflow task

* #13469 Adding the multi language step/action workflows

* #13469 codacy feedback

* Issue 11265 create 4 eyes workflow actionlet (#13366)

* #11265 : Adding initial version of the 4-Eyes actionlet.

* #11265 : Adding initial version of the 4-Eyes actionlet.

* #11265 :

- Wrapping up changes in the 4-eyes approval actionlet class.
- Adding utility class for common-use methods in actionlets.

* #11265 : Adding new type of actionlet parameter that includes validation of role keys.

* #11265 : Codacy and Sonar code changes.

* #11265 : More Codacy and Sonar code changes.

* #11265 : First draft of integration test. Fixing exception throws where the original exception was being swallowed.

* #11265 : Adding more tests to the four-eye sub-action integration test.

* #13333 need to add action of add to bundle to content types - Adding message keus (#13516)

* Missing import

* Fix TreeTransformer and ContentletTransformer (#13518)

TreeTransformer: Use conversion utils instead of a class for Oracle.
TransformerLocator: create only TreeTransformer
ContentletTransformer: Use conversion utils to avoid classCastException in oracle

* #13375 fix starting up oracle, bc join never finds inode column (#13519)

* Remove invalid import.

* Fixing failing Jenkins tests. (#13517)

* changes to build docker image from gradle file - still need to upgrade gradle wrapper version

* cosmetic commit to build.gradle

* changed docker tags and added blank line at end of file

* upgraded gradle wrapper to 4.4.1

* 4.4.1 gradle wrapper

* added reference comment

* fixes #13527
@DeanGonzalez
Copy link

Passed, had trouble dropping fields on a new content type, but will report that on separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants