-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22706 cli testscontainers and test reporting improvements #25885
Merged
nollymar
merged 15 commits into
master
from
22706-cli-testscontainers-and-test-reporting-improvements
Aug 29, 2023
Merged
22706 cli testscontainers and test reporting improvements #25885
nollymar
merged 15 commits into
master
from
22706-cli-testscontainers-and-test-reporting-improvements
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It's possible to enable/disable testcontainers properties. * Modifying some maven configurations.
…ts' of github.com:dotCMS/core into 22706-cli-testscontainers-and-test-reporting-improvements
…ontainers-and-test-reporting-improvements
jdotcms
approved these changes
Aug 28, 2023
nollymar
reviewed
Aug 28, 2023
<artifactId>junit-jupiter</artifactId> | ||
<scope>test</scope> | ||
</dependency> | ||
<!-- <dependency>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need these artifacts commented? shouldn't we just remove them?
…ontainers-and-test-reporting-improvements
nollymar
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #22706
🤖 Generated by Copilot at 4589d26
This pull request introduces several changes related to the integration testing of the
api-data-model
andcli
modules of the dotCMS CLI tool. It enables and configures the Testcontainers library for both modules, renames some test and helper classes to improve consistency and clarity, modifies the Maven build and the GitHub workflow to handle test failures and generate the Allure test report, and removes some unused imports from the test classes.🤖 Generated by Copilot at 4589d26
testcontainers.enabled
property to theapplication.properties
files of theapi-data-model
andcli
modules, with a default value oftrue
, to enable the Testcontainers usage by default for integration testing (link, link)testcontainers.dotcms.license.file
property to include a default value of/path/to/license/file.dat
in theapplication.properties
files of theapi-data-model
andcli
modules, to make the Testcontainers configuration more clear and avoid errors when the property is not set (link, link)TESTCONTAINERS_ENABLED
constant to theContainerResource
classes of theapi-data-model
andcli
modules, to make the Testcontainers usage configurable and optional by reading thetestcontainers.enabled
property (link, link)startContainers
andstopContainers
methods of theContainerResource
classes of theapi-data-model
andcli
modules, to check the value of theTESTCONTAINERS_ENABLED
constant before starting or stopping the Docker containers, and to skip the Testcontainers startup or shutdown when the constant isfalse
(link, link, link, link)<test.failure.ignore>
property fromtrue
tofalse
in thepom.xml
files of theapi-data-model
andcli
modules, to make the Maven build fail fast and report the test failures as soon as possible (link, link)./mvnw clean verify
command in the.github/workflows/cli-cicd-test.yml
file, to add the-Dtest.failure.ignore=true
option, to allow the Maven build to continue even if some tests fail and to enable the generation of the Allure test report (link).allure
directories to the.gitignore
file of thetools/dotcms-cli
module, to prevent these directories from being tracked by Git and avoid unnecessary files in the repository (link)FilesTestHelper
class toFilesHelperIntegrationTest
in thecli
module, to make the name of the helper class more consistent and descriptive for integration testing purposes (link, link, link, link, link, link, link, link)RemoteTraversalServiceTest
class toRemoteTraversalServiceIntegrationTest
in thecli
module, to make the name of the test class more consistent and descriptive for integration testing purposes (link, link)FilesPullCommandTest
class toFilesPullCommandIntegrationTest
in thecli
module, to make the name of the test class more consistent and descriptive for integration testing purposes (link)Test
andLogger
classes from theContainerTest
classes of theapi-data-model
andcli
modules, to clean up the code and follow the best practices of Java coding (link, link)