Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GHA to run CLI tests #22706

Closed
Tracked by #24753
nollymar opened this issue Aug 9, 2022 · 6 comments · Fixed by #25885 or #25963
Closed
Tracked by #24753

Implement GHA to run CLI tests #22706

nollymar opened this issue Aug 9, 2022 · 6 comments · Fixed by #25885 or #25963
Labels
Merged QA : Not Needed QA : Passed Internal Team : Scout Type : Enhancement

Comments

@nollymar
Copy link
Contributor

nollymar commented Aug 9, 2022 •
edited
Loading

Parent Issue
#24753

A GHA should be implemented to run CLI tests (if needed) and generate a report. It's important to consider:
@stale
Copy link

stale bot commented Dec 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2022
@stale stale bot closed this as completed Dec 8, 2022
@nollymar nollymar reopened this Apr 26, 2023
@nollymar nollymar removed the stale label Apr 26, 2023
@nollymar nollymar moved this from New to Current Sprint Backlog in dotCMS - Product Planning Apr 26, 2023
@nollymar nollymar mentioned this issue Apr 26, 2023
Closed
9 tasks
@nollymar nollymar moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Jun 30, 2023
dcolina added a commit that referenced this issue Jul 3, 2023
@dcolina
#22706 Adding a new GHA for running CLI tests.
00da6a0
dcolina added a commit that referenced this issue Jul 3, 2023
@dcolina
#22706 First commit GHA to run CLI tests.
bf5584d
dcolina added a commit that referenced this issue Jul 3, 2023
@dcolina
#22706 Implements dotCMS docker runner as GHA.
1cceeae
dcolina added a commit that referenced this issue Jul 3, 2023
@dcolina
#22706 Testing docker-compose deployment.
549824d
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 testing workflow with inline sh commands.
7afd31e
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 testing gha trigger
6bb43af
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 triggering workflow for gha cli
34b25cd
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 testing docker-compose command.
62165b6
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 Testing docker-compose command
20b1a47
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 testing gradlew test command
be5804a
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 testing gradlew test command
cff1b80
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 testing gradlew test command
43008b2
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 testing run-cli-tests step
51fd803
dcolina added a commit that referenced this issue Jul 5, 2023
@dcolina
#22706 testing mvnw test command
66b3df1
dcolina added a commit that referenced this issue Jul 11, 2023
@dcolina
#22706 Some tests using testcontainers.
74b0094
dcolina added a commit that referenced this issue Jul 11, 2023
@dcolina
#22706 Another test configuration using testcontainers.
4582b53
dcolina added a commit that referenced this issue Jul 11, 2023
@dcolina
#22706 Testing testcontainers on cloud using GHA.
93620b4
dcolina added a commit that referenced this issue Aug 31, 2023
@dcolina
#22706 Fixing cli tests reporting status (error cases).
fec6a4b
dcolina added a commit that referenced this issue Aug 31, 2023
@dcolina
#22706 Building CORE docker image for current commit before running c…
79feafa 
…li testcontainers tests.
@dcolina dcolina mentioned this issue Aug 31, 2023
Merged
dcolina added a commit that referenced this issue Aug 31, 2023
@dcolina
#22706 Fixing build image docker stage on GHA
05245ac
dcolina added a commit that referenced this issue Aug 31, 2023
@dcolina
#22706 Fixing docker build stage on GHA.
c86f58e
@dcolina dcolina moved this from In Progress to In Review in dotCMS - Product Planning Aug 31, 2023
@dcolina
Copy link
Contributor

dcolina commented Aug 31, 2023

Now the reports are shown correctly. Surefire excludes files with the pattern */**IntegrationTest.java.

dcolina added a commit that referenced this issue Aug 31, 2023
@dcolina
#22706 Fix on checking for test failures and errors.
bddd6d1
dcolina added a commit that referenced this issue Sep 1, 2023
@dcolina
#22706 Removing surefire plugin.
808ac93
dcolina added a commit that referenced this issue Sep 1, 2023
@dcolina
#22706 Enabling cache on the docker image build step.
867b147
dcolina added a commit that referenced this issue Sep 1, 2023
@dcolina
#22706 Updating CLI GHA triggers.
4c0d4ea
@nollymar nollymar linked a pull request Sep 6, 2023 that will close this issue
22706 cli testcontainers configuration improvements #25963
Merged
nollymar pushed a commit that referenced this issue Sep 6, 2023
@dcolina
22706 cli testcontainers configuration improvements (#25963)
49ab573 
* #22706 Excluding integration tests of surefire plugin.

* #22706 Fixing cli tests reporting status (error cases).

* #22706 Building CORE docker image for current commit before running cli testcontainers tests.

* #22706 Fixing build image docker stage on GHA

* #22706 Fixing docker build stage on GHA.

* #22706 Fix on checking for test failures and errors.

* #22706 Removing surefire plugin.

* #22706 Enabling cache on the docker image build step.

* #22706 Updating CLI GHA triggers.

---------

Co-authored-by: daniel.colina <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Sep 6, 2023
@nollymar nollymar moved this from Done to Internal QA in dotCMS - Product Planning Sep 6, 2023
@nollymar nollymar assigned fabrizzio-dotCMS and unassigned dcolina Sep 6, 2023
@nollymar nollymar reopened this Sep 6, 2023
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Sep 6, 2023
@nollymar nollymar moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Sep 6, 2023
@fabrizzio-dotCMS fabrizzio-dotCMS removed their assignment Sep 13, 2023
@fabrizzio-dotCMS
Copy link
Contributor

I verified that the reports were shown correctly and also that changes made in the backend were getting picked.
I'm passing it.

@nollymar nollymar moved this from Internal QA to Done in dotCMS - Product Planning Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged QA : Not Needed QA : Passed Internal Team : Scout Type : Enhancement
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
3 participants
@nollymar @dcolina @fabrizzio-dotCMS